diff options
author | Pi-Hsun Shih <pihsun@chromium.org> | 2019-09-04 14:26:13 +0800 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-10-05 15:12:39 +0200 |
commit | d0b85a37c06b3495ecf8268c7670339af3a21fce (patch) | |
tree | 13311f3aa83f411b7fb34b22c97721d1006664a7 /scripts/Makefile.headersinst | |
parent | bec8c6dec6058e4657ceab0fdae5a4ef0c041d3c (diff) |
platform/chrome: cros_ec_rpmsg: Fix race with host command when probe failed
[ Upstream commit 71cddb7097e2b0feb855d7fd7d59afd12cbee4bb ]
Since the rpmsg_endpoint is created before probe is called, it's
possible that a host event is received during cros_ec_register, and
there would be some pending work in the host_event_work workqueue while
cros_ec_register is called.
If cros_ec_register fails, when the leftover work in host_event_work
run, the ec_dev from the drvdata of the rpdev could be already set to
NULL, causing kernel crash when trying to run cros_ec_get_next_event.
Fix this by creating the rpmsg_endpoint by ourself, and when
cros_ec_register fails (or on remove), destroy the endpoint first (to
make sure there's no more new calls to cros_ec_rpmsg_callback), and then
cancel all works in the host_event_work workqueue.
Cc: stable@vger.kernel.org
Fixes: 2de89fd98958 ("platform/chrome: cros_ec: Add EC host command support using rpmsg")
Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'scripts/Makefile.headersinst')
0 files changed, 0 insertions, 0 deletions