diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2022-03-04 16:14:49 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2022-03-07 13:14:47 +0000 |
| commit | 899a9a7f624b5a9d100c9ac6b3f0960981f0e4c5 (patch) | |
| tree | f5257d467056371d269c87808138d849fa0de03c /sound/soc/amd/acp | |
| parent | 8f2b025abc31bc15d38657d1286d7470bbbd5efa (diff) | |
ASoC: amd: acp: Fix signedness bug in renoir_audio_probe()
The "adata->i2s_irq" is unsigned so this error handling will not
work.
Fixes: 3304a242f45a ("ASoC: amd: Use platform_get_irq_byname() to get the interrupt")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20220304131449.GC28739@kili
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/amd/acp')
| -rw-r--r-- | sound/soc/amd/acp/acp-renoir.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/sound/soc/amd/acp/acp-renoir.c b/sound/soc/amd/acp/acp-renoir.c index 738cf2e2b973..75c9229ece97 100644 --- a/sound/soc/amd/acp/acp-renoir.c +++ b/sound/soc/amd/acp/acp-renoir.c @@ -282,9 +282,10 @@ static int renoir_audio_probe(struct platform_device *pdev) if (!adata->acp_base) return -ENOMEM; - adata->i2s_irq = platform_get_irq_byname(pdev, "acp_dai_irq"); - if (adata->i2s_irq < 0) - return -ENODEV; + ret = platform_get_irq_byname(pdev, "acp_dai_irq"); + if (ret < 0) + return ret; + adata->i2s_irq = ret; adata->dev = dev; adata->dai_driver = acp_renoir_dai; |