diff options
| author | Nicholas Mc Guire <hofrat@osadl.org> | 2018-06-29 19:07:42 +0200 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2018-12-16 22:08:07 +0000 |
| commit | b360bd40db35a0bf956b5a5defdb982f45476381 (patch) | |
| tree | 4b8ecab6ab0da3d1a12548fd8cd892713874abc4 /sound | |
| parent | 88cba9483cb429fd54b215f98905efe6e704524d (diff) | |
ALSA: snd-aoa: add of_node_put() in error path
commit 222bce5eb88d1af656419db04bcd84b2419fb900 upstream.
Both calls to of_find_node_by_name() and of_get_next_child() return a
node pointer with refcount incremented thus it must be explicidly
decremented here after the last usage. As we are assured to have a
refcounted np either from the initial
of_find_node_by_name(NULL, name); or from the of_get_next_child(gpio, np)
in the while loop if we reached the error code path below, an
x of_node_put(np) is needed.
Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Fixes: commit f3d9478b2ce4 ("[ALSA] snd-aoa: add snd-aoa")
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'sound')
| -rw-r--r-- | sound/aoa/core/gpio-feature.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/sound/aoa/core/gpio-feature.c b/sound/aoa/core/gpio-feature.c index f34153962d07..585b594bd838 100644 --- a/sound/aoa/core/gpio-feature.c +++ b/sound/aoa/core/gpio-feature.c @@ -88,8 +88,10 @@ static struct device_node *get_gpio(char *name, } reg = of_get_property(np, "reg", NULL); - if (!reg) + if (!reg) { + of_node_put(np); return NULL; + } *gpioptr = *reg; |