summaryrefslogtreecommitdiff
path: root/tools/gpio
diff options
context:
space:
mode:
authorKent Gibson <warthog618@gmail.com>2020-12-28 00:10:40 +0800
committerBartosz Golaszewski <bgolaszewski@baylibre.com>2021-01-03 16:32:21 +0100
commit2e202ad873365513c6ad72e29a531071dffa498a (patch)
tree3e2e0f917ab66ded76ff46f7ddd47b783400e784 /tools/gpio
parent5c8fe583cce542aa0b84adc939ce85293de36e5e (diff)
gpiolib: cdev: fix frame size warning in gpio_ioctl()
The kernel test robot reports the following warning in [1]: drivers/gpio/gpiolib-cdev.c: In function 'gpio_ioctl': >>drivers/gpio/gpiolib-cdev.c:1437:1: warning: the frame size of 1040 bytes is larger than 1024 bytes [-Wframe-larger-than=] Refactor gpio_ioctl() to handle each ioctl in its own helper function and so reduce the variables stored on the stack to those explicitly required to service the ioctl at hand. The lineinfo_get_v1() helper handles both the GPIO_GET_LINEINFO_IOCTL and GPIO_GET_LINEINFO_WATCH_IOCTL, as per the corresponding v2 implementation - lineinfo_get(). [1] https://lore.kernel.org/lkml/202012270910.VW3qc1ER-lkp@intel.com/ Fixes: aad955842d1c ("gpiolib: cdev: support GPIO_V2_GET_LINEINFO_IOCTL and GPIO_V2_GET_LINEINFO_WATCH_IOCTL") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Kent Gibson <warthog618@gmail.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Diffstat (limited to 'tools/gpio')
0 files changed, 0 insertions, 0 deletions