From 5fd593b8736c5e4d0164536e471cb04158b0ab61 Mon Sep 17 00:00:00 2001 From: Sakari Ailus Date: Thu, 21 Dec 2023 15:49:39 +0200 Subject: media: mc: Drop useless debug print on file handle release Drop a debug print in media_release(), which is a release callback for a file handle. Printing a debug message here is simply not necessary. Signed-off-by: Sakari Ailus Reviewed-by: Laurent Pinchart Signed-off-by: Hans Verkuil --- drivers/media/mc/mc-devnode.c | 1 - 1 file changed, 1 deletion(-) (limited to 'drivers/media/mc/mc-devnode.c') diff --git a/drivers/media/mc/mc-devnode.c b/drivers/media/mc/mc-devnode.c index 680fbb3a9340..9c8fe9335dc1 100644 --- a/drivers/media/mc/mc-devnode.c +++ b/drivers/media/mc/mc-devnode.c @@ -190,7 +190,6 @@ static int media_release(struct inode *inode, struct file *filp) return value is ignored. */ put_device(&devnode->dev); - pr_debug("%s: Media Release\n", __func__); return 0; } -- cgit v1.2.3 From e248cde98470ca3d9449e2b744b11279681f8e18 Mon Sep 17 00:00:00 2001 From: "Ricardo B. Marliere" Date: Sat, 3 Feb 2024 12:31:27 -0300 Subject: media: media-devnode: make media_bus_type const Now that the driver core can properly handle constant struct bus_type, move the media_bus_type variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Cc: Greg Kroah-Hartman Suggested-by: Greg Kroah-Hartman Signed-off-by: Ricardo B. Marliere Reviewed-by: Laurent Pinchart Signed-off-by: Hans Verkuil --- drivers/media/mc/mc-devnode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/media/mc/mc-devnode.c') diff --git a/drivers/media/mc/mc-devnode.c b/drivers/media/mc/mc-devnode.c index 9c8fe9335dc1..7f67825c8757 100644 --- a/drivers/media/mc/mc-devnode.c +++ b/drivers/media/mc/mc-devnode.c @@ -63,7 +63,7 @@ static void media_devnode_release(struct device *cd) pr_debug("%s: Media Devnode Deallocated\n", __func__); } -static struct bus_type media_bus_type = { +static const struct bus_type media_bus_type = { .name = MEDIA_NAME, }; -- cgit v1.2.3