From ae053253a7971b6c97ad570e0f373974ca6d7e06 Mon Sep 17 00:00:00 2001 From: Hema Prathaban Date: Tue, 14 May 2013 20:59:19 +0530 Subject: staging: rtl8192e: Fix potential null dereference check memory is allocated in '*challenge' before using it. Signed-off-by: Hema Prathaban Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtllib_softmac.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'drivers/staging/rtl8192e') diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c index 4feecec8609c..8af0b9902615 100644 --- a/drivers/staging/rtl8192e/rtllib_softmac.c +++ b/drivers/staging/rtl8192e/rtllib_softmac.c @@ -1802,7 +1802,9 @@ static inline u16 auth_parse(struct sk_buff *skb, u8** challenge, int *chlen) if (*(t++) == MFIE_TYPE_CHALLENGE) { *chlen = *(t++); *challenge = kmalloc(*chlen, GFP_ATOMIC); - memcpy(*challenge, t, *chlen); /*TODO - check here*/ + if (!*challenge) + return -ENOMEM; + memcpy(*challenge, t, *chlen); } } return cpu_to_le16(a->status); -- cgit v1.2.3