From 19e55a87ad621b1ccba52ba781d29d97220154de Mon Sep 17 00:00:00 2001 From: Evgeny Novikov Date: Mon, 6 Jul 2020 18:53:28 +0300 Subject: fbdev: sm712fb: set error code in probe If smtcfb_pci_probe() does not detect a valid chip it cleans up everything and returns 0. This can result in various bad things later. The patch sets the error code on the corresponding path. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Evgeny Novikov Cc: Sudip Mukherjee Cc: Teddy Wang Signed-off-by: Bartlomiej Zolnierkiewicz Link: https://patchwork.freedesktop.org/patch/msgid/20200706155328.8396-1-novikov@ispras.ru --- drivers/video/fbdev/sm712fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/video') diff --git a/drivers/video/fbdev/sm712fb.c b/drivers/video/fbdev/sm712fb.c index 8cd655d6d628..bdbe9c68e274 100644 --- a/drivers/video/fbdev/sm712fb.c +++ b/drivers/video/fbdev/sm712fb.c @@ -1616,7 +1616,7 @@ static int smtcfb_pci_probe(struct pci_dev *pdev, default: dev_err(&pdev->dev, "No valid Silicon Motion display chip was detected!\n"); - + err = -ENODEV; goto failed_fb; } -- cgit v1.2.3