From 9688fed35a3507e8d8962f2659861acae54b7e69 Mon Sep 17 00:00:00 2001 From: "Subramaniam C.A" Date: Thu, 6 May 2010 14:52:10 -0500 Subject: SYSLINK: Proc4430 module KW defect fixed for release 24.6 Defect: 'hw_attrs.element_size' might be used uninitialized in this function. hw_attrs is passed to the following function, and if the hw_attrs.mixedSize is set to 1 then element_size is not initialised. status = pte_set(pa, da, HW_PAGE_SIZE_4KB, &hw_attrs); TRM says if mixedSize is supported, then element_size can be ignored. set element_size to 3 (no conversion). Signed-off-by: Hari Kanigeri Signed-off-by: Ramesh Gupta G Signed-off-by: Suman Anna Signed-off-by: Subramaniam C.A --- drivers/dsp/syslink/procmgr/proc4430/ducatienabler.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'drivers') diff --git a/drivers/dsp/syslink/procmgr/proc4430/ducatienabler.c b/drivers/dsp/syslink/procmgr/proc4430/ducatienabler.c index ad87016301f1..9c1403f929a1 100644 --- a/drivers/dsp/syslink/procmgr/proc4430/ducatienabler.c +++ b/drivers/dsp/syslink/procmgr/proc4430/ducatienabler.c @@ -400,6 +400,10 @@ int ducati_mem_map(u32 mpu_addr, u32 ul_virt_addr, DPRINTK("WMD_BRD_MemMap: MMU element size is zero\n"); return -EINVAL; } + } else { + /* If mixedSize set to 1, no conversion is + * required. for element size */ + hw_attrs.element_size = HW_ELEM_SIZE_64BIT; } /* * Do OS-specific user-va to pa translation. -- cgit v1.2.3