From e7cdf879468501b1be6c3ab9add1c9ec056093ab Mon Sep 17 00:00:00 2001 From: Jan Kara Date: Wed, 23 May 2012 15:29:31 +0200 Subject: edquota: Fix editting of more users We reopened temporary file with editted quota limits in O_RDONLY mode after user has edited the limits. This is problematic when edquota is called to edit more users because then we cannot write limits for the next user to the file. So reopen the file O_RDWR mode. Signed-off-by: Jan Kara --- Changelog | 1 + edquota.c | 6 +++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/Changelog b/Changelog index 0e2676d..84020a7 100644 --- a/Changelog +++ b/Changelog @@ -1,4 +1,5 @@ Changes in quota-tools from 4.00 to 4.01 +* fixed edquota(8) for more users (Jan Kara) * remove fixed limit on number of autofs mount points (Jan Kara) * add quota type names to message catalogue (Jan Kara) * typo fixes, message changes for easier i18n (Jan Kara) diff --git a/edquota.c b/edquota.c index ef9fc9b..f433417 100644 --- a/edquota.c +++ b/edquota.c @@ -333,7 +333,11 @@ int main(int argc, char **argv) continue; } close(tmpfd); - if ((tmpfd = open(tmpfil, O_RDONLY)) < 0) + /* + * Open in rw mode because we can reuse the file for + * editting next user as well. + */ + if ((tmpfd = open(tmpfil, O_RDWR)) < 0) die(1, _("Cannot reopen!")); if (readprivs(curprivs, tmpfd) < 0) { errstr(_("Cannot read quotas from file.\n")); -- cgit v1.2.3