From 3ad0b3622cf92989584097787323f00bc7a36c48 Mon Sep 17 00:00:00 2001 From: Petr Pisar Date: Thu, 12 May 2011 13:13:56 +0200 Subject: Make global symbols static as possible There are some calls (e.g. getpwnam(3)) that can lead to dlopening other libraries that could jump to symbol with name clashing to one of global quota symbols. (e.g. Name server switch plug-in nss_db calls dirname(3) that's already defined in edquota.c and tht can cause segmentation fault.) Although it's not possible to solve all these problems, making as much as possible global objects and functions static is the best thing we can do to avoid name space polution. Signed-off-by: Jan Kara --- quot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'quot.c') diff --git a/quot.c b/quot.c index 3e1f8d8..d9114a4 100644 --- a/quot.c +++ b/quot.c @@ -56,8 +56,8 @@ #include "quotasys.h" #define TSIZE 500 -__uint64_t sizes[TSIZE]; -__uint64_t overflow; +static __uint64_t sizes[TSIZE]; +static __uint64_t overflow; static int aflag; static int cflag; -- cgit v1.2.3