From 3ad0b3622cf92989584097787323f00bc7a36c48 Mon Sep 17 00:00:00 2001 From: Petr Pisar Date: Thu, 12 May 2011 13:13:56 +0200 Subject: Make global symbols static as possible There are some calls (e.g. getpwnam(3)) that can lead to dlopening other libraries that could jump to symbol with name clashing to one of global quota symbols. (e.g. Name server switch plug-in nss_db calls dirname(3) that's already defined in edquota.c and tht can cause segmentation fault.) Although it's not possible to solve all these problems, making as much as possible global objects and functions static is the best thing we can do to avoid name space polution. Signed-off-by: Jan Kara --- setquota.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'setquota.c') diff --git a/setquota.c b/setquota.c index c012908..57bd580 100644 --- a/setquota.c +++ b/setquota.c @@ -37,12 +37,12 @@ #define FL_NO_MIXED_PATHS 512 #define FL_CONTINUE_BATCH 1024 -int flags, fmt = -1; -char **mnt; +static int flags, fmt = -1; +static char **mnt; char *progname; -int mntcnt; -qid_t protoid, id; -struct util_dqblk toset; +static int mntcnt; +static qid_t protoid, id; +static struct util_dqblk toset; /* Print usage information */ static void usage(void) -- cgit v1.2.3