diff options
| author | Zorro Lang <zlang@redhat.com> | 2019-01-23 15:34:55 +0800 |
|---|---|---|
| committer | Eryu Guan <guaneryu@gmail.com> | 2019-01-27 11:56:40 +0800 |
| commit | 04b405fa1f8d0cacde489f3d1c8771dfe7a34dc0 (patch) | |
| tree | 728a54bea38cca3efa6ea24e6cb24d4c8773286a /common/dump | |
| parent | 544624ac14de604852a0bf626411acef2307b07d (diff) | |
common/dump: disable splice from FSSTRESS_AVOID
New fsstress operation breaks fs dump/restore testing which use
fsstress, e.g xfs/068.
In _create_dumpdir_stress_num, disable splice in fsstress so that we
dump exactly the same set of files and directories.
Quote Dave's comments for future reference
"
fsstress is just creating regular files differently. It has no
impact on xfsdump does except to change the number of files created
and the directory layout.
If this new functionality were creating a new type of file that
xfsdump has to handle, or adding new attributes or changing the
metadata of the existing files, then we want to make sure xfsdump is
tested against that, and so we'd be changing the golden output after
careful checking that both xfsdump and xfs_restore are working
correctly and the file count is correct.
But when all we are doing is creating normal, regular files just
with a different syscall, it makes no sense to perturb the existing
test then we have to go and validate that the new set of files being
tested is actually scanned correctly, is complete and correct. Using
a blacklist to avoid unnecessary perturbation such as in cases like
this is the right thing to do because we've had to determine if the
new functionality is a useful addition to xfsdump/restore test
coverage or not.
"
[Eryu: add Dave's comments in commit log for future reference]
Signed-off-by: Zorro Lang <zlang@redhat.com>
Suggested-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Eryu Guan <guaneryu@gmail.com>
Diffstat (limited to 'common/dump')
| -rw-r--r-- | common/dump | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/common/dump b/common/dump index 4d1a1607..b17771b9 100644 --- a/common/dump +++ b/common/dump @@ -310,6 +310,9 @@ _create_dumpdir_stress_num() if $FSSTRESS_PROG | grep -q copyrange; then FSSTRESS_AVOID="-f copyrange=0 $FSSTRESS_AVOID" fi + if $FSSTRESS_PROG | grep -q splice; then + FSSTRESS_AVOID="-f splice=0 $FSSTRESS_AVOID" + fi echo "" echo "-----------------------------------------------" |