diff options
| author | Darrick J. Wong <djwong@kernel.org> | 2021-09-16 17:40:06 -0700 |
|---|---|---|
| committer | Eryu Guan <guaneryu@gmail.com> | 2021-09-26 21:36:20 +0800 |
| commit | 344319453e8cfaf3abee5566fff22e29f81c3596 (patch) | |
| tree | ef9c2d60fb1a3611acfa398120523492671ab039 /new | |
| parent | 401a1e5043fa409e73b136837b40a5f7c3f26344 (diff) | |
new: don't allow new tests in group 'other'
The 'other' group is vaguely defined at best -- other than what? It's
not clear what tests belong in this group, and it has become a dumping
ground for random stuff that are classified in other groups. Don't let
people create new other group tests.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Eryu Guan <guaneryu@gmail.com>
Diffstat (limited to 'new')
| -rwxr-xr-x | new | 9 |
1 files changed, 6 insertions, 3 deletions
@@ -100,6 +100,9 @@ check_groups() { echo "Invalid characters in group(s): ${inval}" echo "Only lower cases, digits and underscore are allowed in groups, separated by space" return 1 + elif [ "${g}" = "other" ]; then + echo "Do not add more tests to group \"other\"" + return 1 elif ! group_names | grep -q -w "${g}"; then echo "Warning: group \"${g}\" not defined in documentation" return 1 @@ -111,16 +114,16 @@ check_groups() { if [ $# -eq 0 ]; then # interactive mode - prompt="Add to group(s) [other] (separate by space, ? for list): " + prompt="Add to group(s) [auto] (separate by space, ? for list): " while true; do read -p "${prompt}" -a new_groups || exit 1 case "${#new_groups[@]}" in 0) - new_groups=("other") + new_groups=("auto") ;; 1) if [ "${new_groups[0]}" = "?" ]; then - echo $(group_names) + echo $(group_names | grep -v -w 'other') continue fi ;; |