From c569ebf561802dd43492ccb47df90528645dc7c6 Mon Sep 17 00:00:00 2001 From: Anand Jain Date: Sun, 29 Jan 2023 10:42:32 +0800 Subject: fstests: t_getcwd.c, fix a warning related to buffer overflow GCC reports warning related to 'strncpy' and its specified bound being equal to the destination buffer size. t_getcwd.c: In function 'do_rename': t_getcwd.c:40:2: warning: 'strncpy' specified bound 256 equals destination size [-Wstringop-truncation] strncpy(c_name, prefix, BUF_SIZE); A buffer overflow is unlikely here because the only caller for do_rename() sends a 16 char long %prefix and BUF_SIZE is defined as 256. The change is made to reduce the buffer length in order to silence compilation warning. Signed-off-by: Anand Jain Reviewed-by: Bill O'Donnell Signed-off-by: Zorro Lang --- src/t_getcwd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/t_getcwd.c b/src/t_getcwd.c index 27255bd0..e9b5d7fe 100644 --- a/src/t_getcwd.c +++ b/src/t_getcwd.c @@ -30,14 +30,14 @@ int test_getcwd(char *init_cwd) return 0; } -void do_rename(char *prefix) +static void do_rename(char *prefix) { int i = 0; int fd; char c_name[BUF_SIZE]; char n_name[BUF_SIZE]; - strncpy(c_name, prefix, BUF_SIZE); + strncpy(c_name, prefix, BUF_SIZE - 1); fd = open(c_name, O_CREAT | O_RDWR, 0644); if (fd < 0) { -- cgit v1.2.3