#! /bin/bash
# SPDX-License-Identifier: GPL-2.0
# Copyright (c) 2017 Red Hat Inc.  All Rights Reserved.
#
# FS QA Test 026
#
# Overlayfs should only filter out xattr starting with
# "trusted.overlay.", not "trusted.overlay".
#
# Setting xattrs like "trusted.overlay.xxx" is not allowed.
# Setting xattrs like "trusted.overlayxxx" is allowed.
#
# v4.8-rc1 introduced a regression that we can't set xattrs
# like "trusted.overlayxxx".  Kernel commit below fixed it
# in v4.8:
#   fe2b75952347 ovl: Fix OVL_XATTR_PREFIX
#
# This case tests both get/set of these 2 kinds of xattrs.
#
# Pattern "trusted.overlay.xxx" should fail, however the
# errno returned by set/get varies among kernel versions.
# Pattern "trusted.overlayxxx" shold always work.
#
# This reproducer was originally written by
#     Miklos Szeredi <mszeredi@redhat.com>
#
. ./common/preamble
_begin_fstest auto attr quick

# Import common functions.
. ./common/attr
. ./common/filter

# real QA test starts here

# Modify as appropriate.
_supported_fs overlay
_require_scratch
_require_attrs trusted

# Remove all files from previous tests
_scratch_mkfs

# Mounting overlay
_scratch_mount
touch $SCRATCH_MNT/testf0
touch $SCRATCH_MNT/testf1

# {s,g}etfattr of "trusted.overlayxxx" should work.
#            v4.3/6/7    v4.8-rc1   v4.8  v4.10
# setfattr    ok         not perm    ok    ok
# getfattr    ok         no attr     ok    ok
#
$SETFATTR_PROG -n "trusted.overlayfsrz" -v "n" \
  $SCRATCH_MNT/testf0 2>&1 | tee -a $seqres.full | _filter_scratch

_getfattr --absolute-names -n "trusted.overlayfsrz" \
  $SCRATCH_MNT/testf0 2>&1 | tee -a $seqres.full | _filter_scratch

# {s,g}etfattr of "trusted.overlay.xxx" fail on older kernels
# The errno returned varies among kernel versions,
#            v4.3/7   v4.8-rc1    v4.8       v4.10     v6.7
# setfattr  not perm  not perm   not perm   not supp  ok
# getfattr  no attr   no attr    not perm   not supp  ok
#
# Consider "Operation not {supported,permitted}" pass for old kernels.
#
if _check_scratch_overlay_xattr_escapes $SCRATCH_MNT/testf0; then
	setexp=""
	getexp="No such attribute"
else
	setexp="Operation not supported"
	getexp="Operation not supported"
fi

getres=$(_getfattr --absolute-names -n "trusted.overlay.fsz" \
  $SCRATCH_MNT/testf1 2>&1 | tee -a $seqres.full | _filter_scratch | \
  sed 's/permitted/supported/')

[[ "$getres" =~ "$getexp" ]] || echo unexpected getattr result: $getres

setres=$($SETFATTR_PROG -n "trusted.overlay.fsz" -v "n" \
  $SCRATCH_MNT/testf1 2>&1 | tee -a $seqres.full |_filter_scratch | \
  sed -e 's/permitted/supported/g')

if [ "$setexp" ]; then
	[[ "$setres" =~ "$expres" ]] || echo unexpected setattr result: $setres
else
	[[ "$setres" == "" ]] || echo unexpected setattr result: $setres
fi

# success, all done
status=0
exit