kent/consciousness
1
0
Fork 1
Code Issues 1 Pull requests 5 Projects Releases Packages Wiki Activity Actions

unconscious: move health refresh outside lock too

Browse source 
refresh_health() was doing Store::load() + compute_graph_health()
while holding the Unconscious lock, causing 12 second stalls.

Split into needs_health_refresh() (quick check) and set_health()
(quick store), with the slow I/O happening outside the lock.

Co-Authored-By: Proof of Concept <poc@bcachefs.org>
This commit is contained in:
Kent Overstreet 2026-04-12 20:37:54 -04:00
parent f40d8cfa9d
commit ac6f1e9294
2 changed files with 18 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/mind/mod.rs
View file

@ -346,6 +346,14 @@ impl Mind {
s.unc_idle = true;
}
loop {
// Phase 0: health check outside lock (slow I/O)
let needs_health = unc.lock().await.needs_health_refresh();
if needs_health {
if let Ok(store) = crate::store::Store::load() {
let health = crate::subconscious::daemon::compute_graph_health(&store);
unc.lock().await.set_health(health);
}
}
// Phase 1: quick work under lock
let to_spawn = {
let mut guard = unc.lock().await;