From d5634c0034070331b2d8d742605a96b177096060 Mon Sep 17 00:00:00 2001 From: Kent Overstreet Date: Sun, 8 Mar 2026 20:51:56 -0400 Subject: [PATCH] remove dead code: unused imports, functions, and fields - Remove #![allow(dead_code)] from main.rs, fix all revealed warnings - Delete unused schema_assimilation() from neuro/scoring.rs - Delete duplicate memory_dir() wrapper from knowledge.rs - Deduplicate load_prompt: knowledge.rs now calls neuro::load_prompt - Remove unused timeout field from DigestLevel - Remove unused imports (regex::Regex, Provenance, AnyView, Write) - Mark OldEntry fields as #[allow(dead_code)] (needed for deserialization) Co-Authored-By: ProofOfConcept --- poc-memory/src/daemon.rs | 2 +- poc-memory/src/digest.rs | 4 ---- poc-memory/src/enrich.rs | 1 - poc-memory/src/knowledge.rs | 12 +----------- poc-memory/src/main.rs | 2 +- poc-memory/src/migrate.rs | 1 + poc-memory/src/neuro/scoring.rs | 23 ----------------------- poc-memory/src/query.rs | 2 +- poc-memory/src/store/persist.rs | 2 +- 9 files changed, 6 insertions(+), 43 deletions(-) diff --git a/poc-memory/src/daemon.rs b/poc-memory/src/daemon.rs index 3595d4d..f9a845e 100644 --- a/poc-memory/src/daemon.rs +++ b/poc-memory/src/daemon.rs @@ -338,7 +338,7 @@ pub fn run_daemon() -> Result<(), String> { // Load fact-mined keys too let fact_keys: HashSet = { - use crate::store::{AnyView, StoreView}; + use crate::store::StoreView; let view = crate::store::AnyView::load().ok(); view.map(|v| { let mut keys = HashSet::new(); diff --git a/poc-memory/src/digest.rs b/poc-memory/src/digest.rs index 161d09b..aa8b638 100644 --- a/poc-memory/src/digest.rs +++ b/poc-memory/src/digest.rs @@ -20,7 +20,6 @@ struct DigestLevel { title: &'static str, period: &'static str, input_title: &'static str, - timeout: u64, child_name: Option<&'static str>, // None = journal (leaf), Some = child digest files /// Expand an arg into (canonical_label, dates covered). label_dates: fn(&str) -> Result<(String, Vec), String>, @@ -33,7 +32,6 @@ const DAILY: DigestLevel = DigestLevel { title: "Daily", period: "Date", input_title: "Journal entries", - timeout: 300, child_name: None, label_dates: |date| Ok((date.to_string(), vec![date.to_string()])), date_to_label: |date| Some(date.to_string()), @@ -57,7 +55,6 @@ const WEEKLY: DigestLevel = DigestLevel { title: "Weekly", period: "Week", input_title: "Daily digests", - timeout: 300, child_name: Some("daily"), label_dates: |arg| { if !arg.contains('W') { @@ -82,7 +79,6 @@ const MONTHLY: DigestLevel = DigestLevel { title: "Monthly", period: "Month", input_title: "Weekly digests", - timeout: 600, child_name: Some("weekly"), label_dates: |arg| { let (year, month) = if arg.len() <= 7 { diff --git a/poc-memory/src/enrich.rs b/poc-memory/src/enrich.rs index f2f1db0..4a4e240 100644 --- a/poc-memory/src/enrich.rs +++ b/poc-memory/src/enrich.rs @@ -11,7 +11,6 @@ use crate::llm::{call_sonnet, parse_json_response, semantic_keys}; use crate::neuro; use crate::store::{self, Store, new_node, new_relation}; -use regex::Regex; use std::collections::hash_map::DefaultHasher; use std::collections::HashSet; use std::fs; diff --git a/poc-memory/src/knowledge.rs b/poc-memory/src/knowledge.rs index a66bd39..867e13e 100644 --- a/poc-memory/src/knowledge.rs +++ b/poc-memory/src/knowledge.rs @@ -21,15 +21,6 @@ use std::collections::{HashMap, HashSet}; use std::fs; use std::path::{Path, PathBuf}; -fn memory_dir() -> PathBuf { - store::memory_dir() -} - -fn prompts_dir() -> PathBuf { - let manifest = env!("CARGO_MANIFEST_DIR"); - PathBuf::from(manifest).join("prompts") -} - fn projects_dir() -> PathBuf { let home = std::env::var("HOME").unwrap_or_else(|_| ".".into()); PathBuf::from(home).join(".claude/projects") @@ -339,8 +330,7 @@ fn agent_provenance(agent: &str) -> store::Provenance { // --------------------------------------------------------------------------- fn load_prompt(name: &str) -> Result { - let path = prompts_dir().join(format!("{}.md", name)); - fs::read_to_string(&path).map_err(|e| format!("load prompt {}: {}", name, e)) + crate::neuro::load_prompt(name, &[]) } fn get_graph_topology(store: &Store, graph: &Graph) -> String { diff --git a/poc-memory/src/main.rs b/poc-memory/src/main.rs index 7f09c8f..1475468 100644 --- a/poc-memory/src/main.rs +++ b/poc-memory/src/main.rs @@ -1,4 +1,4 @@ -#![allow(dead_code)] + // poc-memory: graph-structured memory for AI assistants // // Authors: ProofOfConcept and Kent Overstreet diff --git a/poc-memory/src/migrate.rs b/poc-memory/src/migrate.rs index 86e6a22..1554784 100644 --- a/poc-memory/src/migrate.rs +++ b/poc-memory/src/migrate.rs @@ -40,6 +40,7 @@ struct OldStore { } #[derive(Deserialize)] +#[allow(dead_code)] // fields needed for deserialization of old format struct OldEntry { weight: f64, created: String, diff --git a/poc-memory/src/neuro/scoring.rs b/poc-memory/src/neuro/scoring.rs index 1ce32f6..a7f89c5 100644 --- a/poc-memory/src/neuro/scoring.rs +++ b/poc-memory/src/neuro/scoring.rs @@ -163,29 +163,6 @@ pub fn detect_interference( .collect() } -/// Schema assimilation scoring for a new node. -/// Returns how easily the node integrates into existing structure. -/// -/// High fit (>0.5): auto-link, done -/// Medium fit (0.2-0.5): agent reviews, proposes links -/// Low fit (<0.2): deep examination needed — new schema seed, bridge, or noise? -pub fn schema_assimilation(store: &Store, key: &str) -> (f32, &'static str) { - let graph = store.build_graph(); - let fit = graph.clustering_coefficient(key); - - let recommendation = if fit > 0.5 { - "auto-integrate" - } else if fit > 0.2 { - "agent-review" - } else if graph.degree(key) > 0 { - "deep-examine-bridge" - } else { - "deep-examine-orphan" - }; - - (fit, recommendation) -} - /// Agent allocation from the control loop pub struct ConsolidationPlan { pub replay_count: usize, diff --git a/poc-memory/src/query.rs b/poc-memory/src/query.rs index abba2a2..96157bb 100644 --- a/poc-memory/src/query.rs +++ b/poc-memory/src/query.rs @@ -21,7 +21,7 @@ // key ~ 'journal.*' AND degree > 10 | count // * | sort weight asc | limit 20 -use crate::store::{NodeType, Provenance, RelationType, Store}; +use crate::store::{NodeType, RelationType, Store}; use crate::graph::Graph; use regex::Regex; use std::collections::BTreeMap; diff --git a/poc-memory/src/store/persist.rs b/poc-memory/src/store/persist.rs index 4984cad..f0b3ae5 100644 --- a/poc-memory/src/store/persist.rs +++ b/poc-memory/src/store/persist.rs @@ -16,7 +16,7 @@ use capnp::serialize; use std::collections::HashMap; use std::fs; -use std::io::{BufReader, BufWriter, Seek, Write as IoWrite}; +use std::io::{BufReader, BufWriter, Seek}; use std::path::Path; impl Store {