0e6b5dc8be
bail-no-competing.sh used to bail if any other live agent existed in the state dir, period. That was too coarse: surface-observe agents run a multi-step pipeline (surface → organize-search → organize-new → observe), and the intent is to let a new surface-phase agent start while an older one finishes its post-surface tail. With the old check the newer agent always bailed, so surface-observe was effectively serialized at the slowest cycle time. Make the script phase-aware: - oneshot.rs now passes the current phase as argv[2] alongside the pid file name. The script writes that phase into its own pid file on every step transition, so concurrent agents can read each other's phase just by cat'ing the pid files. - Bail only when another live agent is in the same phase-group as us. Groups: "surface" vs. "everything else" (post-surface). At most one agent per group alive at a time — surface runs at a higher cadence than the organize/observe tail. - Still clean up stale pid files for dead processes. Co-Authored-By: Proof of Concept <poc@bcachefs.org>
50 lines
1.3 KiB
Bash
Executable file
50 lines
1.3 KiB
Bash
Executable file
#!/bin/bash
|
|
# Bail if another agent is in the same phase-group as us.
|
|
#
|
|
# $1 = our pid file name (e.g. "pid-12345")
|
|
# $2 = the phase we're about to enter (e.g. "surface", "observe")
|
|
# cwd = state dir
|
|
#
|
|
# Also refreshes our own pid file with the current phase on each call,
|
|
# so concurrent agents can read each other's phase by cat'ing the pid
|
|
# files in the state dir.
|
|
#
|
|
# Phase groups: "surface" vs everything else ("post-surface"). We allow
|
|
# at most one agent per group to be alive at a time — so surface can run
|
|
# at a higher frequency than the slower organize/observe tail.
|
|
#
|
|
# Exit 0 = continue, exit 1 = bail (another agent in our group is alive).
|
|
|
|
shopt -s nullglob
|
|
|
|
my_pid_file="$1"
|
|
my_phase="$2"
|
|
|
|
# Refresh our own pid file with the current phase.
|
|
printf '%s' "$my_phase" > "$my_pid_file"
|
|
|
|
group_of() {
|
|
if [[ "$1" == "surface" ]]; then
|
|
echo "surface"
|
|
else
|
|
echo "post-surface"
|
|
fi
|
|
}
|
|
|
|
my_group=$(group_of "$my_phase")
|
|
|
|
for f in pid-*; do
|
|
[[ "$f" == "$my_pid_file" ]] && continue
|
|
pid="${f#pid-}"
|
|
if ! kill -0 "$pid" 2>/dev/null; then
|
|
rm -f "$f" # stale pid file, clean up
|
|
continue
|
|
fi
|
|
other_phase=$(cat "$f" 2>/dev/null)
|
|
other_group=$(group_of "$other_phase")
|
|
if [[ "$my_group" == "$other_group" ]]; then
|
|
exit 1
|
|
fi
|
|
done
|
|
|
|
exit 0
|