Agent:🆕 tool definitions from caller's tool list

The system prompt was advertising all tools to every agent, but
the runtime only dispatched the agent's actual subset. This caused
unconscious agents to call tools that returned "Unknown tool."

Agent::new now takes the tool list explicitly. Each caller passes
its own tools — the prompt and runtime always match. MCP tool
definitions are still appended for agents that use them.

Co-Authored-By: Proof of Concept <poc@bcachefs.org>

src/agent/mod.rs

@@ -192,12 +192,15 @@ impl Agent {
         prompt_file: String,
         conversation_log: Option<ConversationLog>,
         active_tools: tools::ActiveTools,
+        agent_tools: Vec<tools::Tool>,
     ) -> Arc<Self> {
         let mut context = ContextState::new();
         context.conversation_log = conversation_log;
         context.push_no_log(Section::System, AstNode::system_msg(&system_prompt));
 
-        let tool_defs = tools::all_tool_definitions().await;
+        let mut tool_defs: Vec<String> = agent_tools.iter().map(|t| t.to_json()).collect();
+        tool_defs.extend(tools::all_mcp_tool_definitions().await);
+
         if !tool_defs.is_empty() {
             let tools_text = format!(
                 "# Tools\n\nYou have access to the following functions:\n\n<tools>\n{}\n</tools>\n\n\
@@ -223,7 +226,7 @@ impl Agent {
             session_id,
             context: tokio::sync::Mutex::new(context),
             state: tokio::sync::Mutex::new(AgentState {
-                tools: tools::tools(),
+                tools: agent_tools,
                 mcp_tools: McpToolAccess::All,
                 last_prompt_tokens: 0,
                 reasoning_effort: "none".to_string(),

src/agent/oneshot.rs

@@ -138,6 +138,7 @@ impl AutoAgent {
             app, String::new(),
             None,
             super::tools::ActiveTools::new(),
+            super::tools::tools(),
         ).await;
         {
             let mut st = agent.state.lock().await;

src/agent/tools/mod.rs

@@ -195,6 +195,10 @@ pub async fn all_tool_definitions() -> Vec<String> {
     defs
 }
 
+pub async fn all_mcp_tool_definitions() -> Vec<String> {
+    mcp_client::tool_definitions_json().await
+}
+
 /// Memory + journal tools only — for subconscious agents.
 pub fn memory_and_journal_tools() -> Vec<Tool> {
     let mut all = memory::memory_tools().to_vec();

src/mind/mod.rs

@@ -298,6 +298,7 @@ impl Mind {
             config.prompt_file.clone(),
             conversation_log,
             crate::agent::tools::ActiveTools::new(),
+            crate::agent::tools::tools(),
         ).await;
 
         let shared = Arc::new(std::sync::Mutex::new(MindState::new(config.app.dmn.max_turns)));

src/mind/unconscious.rs

@@ -282,11 +282,11 @@ impl Unconscious {
             client, system_prompt, personality,
             app, String::new(), None,
             crate::agent::tools::ActiveTools::new(),
+            auto.tools.clone(),
         ).await;
         {
             let mut st = agent.state.lock().await;
             st.provenance = format!("unconscious:{}", auto.name);
-            st.tools = auto.tools.clone();
             st.priority = Some(10);
         }