path: root/.cocciconfig
diff options
authorBrian Norris <>2016-11-09 17:21:08 -0800
committerGreg Kroah-Hartman <>2016-11-26 09:56:57 +0100
commit4cba876de64d448b458dd271f49c0e6a80a639ce (patch)
tree62e223e35f410674e95133b6bd259728a6d6eda9 /.cocciconfig
parent2e2c8f0e7502fe8a8b6879af6bc8957b949bf1af (diff)
PM / sleep: don't suspend parent when async child suspend_{noirq, late} fails
commit 6f75c3fd56daf547d684127a7f83c283c3c160d1 upstream. Consider two devices, A and B, where B is a child of A, and B utilizes asynchronous suspend (it does not matter whether A is sync or async). If B fails to suspend_noirq() or suspend_late(), or is interrupted by a wakeup (pm_wakeup_pending()), then it aborts and sets the async_error variable. However, device A does not (immediately) check the async_error variable; it may continue to run its own suspend_noirq()/suspend_late() callback. This is bad. We can resolve this problem by doing our error and wakeup checking (particularly, for the async_error flag) after waiting for children to suspend, instead of before. This also helps align the logic for the noirq and late suspend cases with the logic in __device_suspend(). It's easy to observe this erroneous behavior by, for example, forcing a device to sleep a bit in its suspend_noirq() (to ensure the parent is waiting for the child to complete), then return an error, and watch the parent suspend_noirq() still get called. (Or similarly, fake a wakeup event at the right (or is it wrong?) time.) Fixes: de377b397272 (PM / sleep: Asynchronous threads for suspend_late) Fixes: 28b6fd6e3779 (PM / sleep: Asynchronous threads for suspend_noirq) Reported-by: Jeffy Chen <> Signed-off-by: Brian Norris <> Signed-off-by: Rafael J. Wysocki <> Signed-off-by: Greg Kroah-Hartman <>
Diffstat (limited to '.cocciconfig')
0 files changed, 0 insertions, 0 deletions