path: root/drivers/gpu
diff options
authorRyan Mallon <>2012-01-28 08:51:40 +1100
committerDave Airlie <>2012-01-30 09:32:39 +0000
commitbf9c05d5b6d19b3e4c9fe21047694e94f48db89b (patch)
tree0c5728cdd5ad4bcc8fb770a78d1521f1113f2d8a /drivers/gpu
parent1ffd57c1da2a73b0a0e5cd7a6dd52cc49e36bef9 (diff)
vmwgfx: Fix assignment in vmw_framebuffer_create_handle
The assignment of handle in vmw_framebuffer_create_handle doesn't actually do anything useful and is incorrectly assigning an integer value to a pointer argument. It appears that this is a typo and should be dereferencing handle rather than assigning to it directly. This fixes a bug where an undefined handle value is potentially returned to user-space. Signed-off-by: Ryan Mallon <> Reviewed-by: Jakob Bornecrantz<> Cc: Signed-off-by: Dave Airlie <>
Diffstat (limited to 'drivers/gpu')
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
index 0af6ebdf205d..b66ef0e3cde1 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
@@ -378,7 +378,7 @@ int vmw_framebuffer_create_handle(struct drm_framebuffer *fb,
unsigned int *handle)
if (handle)
- handle = 0;
+ *handle = 0;
return 0;