path: root/drivers
diff options
authorKent Overstreet <>2013-07-11 22:42:14 -0700
committerGreg Kroah-Hartman <>2013-07-28 16:30:10 -0700
commit5e20e8b3713b8a5941891db2626c9eecd3c0888c (patch)
tree56018d65da18a1618cf29eddf37a317d260eee00 /drivers
parent99e56bf5abce5131746397a2ce551fd92ca8f342 (diff)
bcache: Journal replay fix
commit faa5673617656ee58369a3cfe4a312cfcdc59c81 upstream. The journal replay code starts by finding something that looks like a valid journal entry, then it does a binary search over the unchecked region of the journal for the journal entries with the highest sequence numbers. Trouble is, the logic was wrong - journal_read_bucket() returns true if it found journal entries we need, but if the range of journal entries we're looking for loops around the end of the journal - in that case journal_read_bucket() could return true when it hadn't found the highest sequence number we'd seen yet, and in that case the binary search did the wrong thing. Whoops. Signed-off-by: Kent Overstreet <> Signed-off-by: Greg Kroah-Hartman <>
Diffstat (limited to 'drivers')
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/md/bcache/journal.c b/drivers/md/bcache/journal.c
index 8c8dfdcd9d4c..8a54d3b4f517 100644
--- a/drivers/md/bcache/journal.c
+++ b/drivers/md/bcache/journal.c
@@ -182,9 +182,14 @@ bsearch:
pr_debug("starting binary search, l %u r %u", l, r);
while (l + 1 < r) {
+ seq = list_entry(list->prev, struct journal_replay,
+ list)->j.seq;
m = (l + r) >> 1;
+ read_bucket(m);
- if (read_bucket(m))
+ if (seq != list_entry(list->prev, struct journal_replay,
+ list)->j.seq)
l = m;
r = m;