path: root/include
diff options
authorKenji Kaneshige <>2009-05-26 09:08:03 +0900
committerLen Brown <>2009-05-27 17:53:07 -0400
commitdacd2549ca61ddbdd1ed62a76ca95dea3f0e02c6 (patch)
treee2369849d60890e3f5596b52346aefc74ce414c5 /include
parentcd86a536c81e9300d984327517548ca0652eebf9 (diff)
PCI/ACPI: fix wrong ref count handling in acpi_pci_bind()
The 'dev' field of struct acpi_pci_data is having a pointer to struct pci_dev without incrementing the reference counter. Because of this, I got the following kernel oops when I was doing some pci hotplug operations. This patch fixes this bug by replacing wrong hand-made pci_find_slot() with pci_get_slot() in acpi_pci_bind(). BUG: unable to handle kernel NULL pointer dereference at 00000000000000e8 IP: [<ffffffff803f0e9b>] acpi_pci_unbind+0xb1/0xdd Call Trace: [<ffffffff803ecee4>] acpi_bus_remove+0x54/0x68 [<ffffffff803ecf6d>] acpi_bus_trim+0x75/0xe3 [<ffffffffa0345ddd>] acpiphp_disable_slot+0x16d/0x1e0 [acpiphp] [<ffffffffa03441f0>] disable_slot+0x20/0x60 [acpiphp] [<ffffffff803cfc18>] power_write_file+0xc8/0x110 [<ffffffff803c6a54>] pci_slot_attr_store+0x24/0x30 [<ffffffff803469ce>] sysfs_write_file+0xce/0x140 [<ffffffff802e94e7>] vfs_write+0xc7/0x170 [<ffffffff802e9aa0>] sys_write+0x50/0x90 [<ffffffff8020bd6b>] system_call_fastpath+0x16/0x1b Signed-off-by: Kenji Kaneshige <> Reviewed-by: Bjorn Helgaas <> Reviewed-by: Alex Chiang <> Tested-by: Alex Chiang <> Signed-off-by: Len Brown <>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions