path: root/kernel
diff options
authorOleg Nesterov <>2006-03-28 16:11:20 -0800
committerLinus Torvalds <>2006-03-28 18:36:43 -0800
commit5876700cd399112ecfa70df36203c8c6660d84f8 (patch)
tree3060724c6682ee7452bcb7b3c99eded75cd59ea7 /kernel
parent35f5cad8c4bab94ecc5acdc4055df5ea12dc76f8 (diff)
[PATCH] do __unhash_process() under ->siglock
This patch moves __unhash_process() call from realease_task() to __exit_signal(), so __detach_pid() is called with ->siglock held. This means we don't need tasklist_lock to iterate over thread group anymore: copy_process() was already changed to do attach_pid() under ->siglock. Eric's "pidhash-kill-switch_exec_pids.patch" from -mm changed de_thread() so it doesn't touch PIDTYPE_TGID. NOTE: de_thread() still needs some attention. It still changes task->pid lockless. Taking ->sighand.siglock here allows to do more tasklist_lock removals. Signed-off-by: Oleg Nesterov <> Signed-off-by: Andrew Morton <> Signed-off-by: Linus Torvalds <>
Diffstat (limited to 'kernel')
1 files changed, 2 insertions, 2 deletions
diff --git a/kernel/exit.c b/kernel/exit.c
index 6b2e4cf3e140..44d6c6e3896d 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -112,6 +112,8 @@ static void __exit_signal(struct task_struct *tsk)
sig = NULL; /* Marker for below. */
+ __unhash_process(tsk);
tsk->signal = NULL;
@@ -140,8 +142,6 @@ repeat:
BUG_ON(!list_empty(&p->ptrace_list) || !list_empty(&p->ptrace_children));
- __unhash_process(p);
* If we are the last non-leader member of the thread
* group, and the leader is zombie, then notify the