path: root/mm/oom_kill.c
diff options
authorOleg Nesterov <>2010-08-09 17:18:44 -0700
committerLinus Torvalds <>2010-08-09 20:44:55 -0700
commitb52279406e77be711c068f9a8e970ea6471e089c (patch)
tree5f44a8af51ccc30847b1d969e0bd36205902d3fb /mm/oom_kill.c
parent455c0e5fb03b67fa62bd12e3abe3fa484b9960c5 (diff)
oom: PF_EXITING check should take mm into account
select_bad_process() checks PF_EXITING to detect the task which is going to release its memory, but the logic is very wrong. - a single process P with the dead group leader disables select_bad_process() completely, it will always return ERR_PTR() while P can live forever - if the PF_EXITING task has already released its ->mm it doesn't make sense to expect it is goiing to free more memory (except task_struct/etc) Change the code to ignore the PF_EXITING tasks without ->mm. Signed-off-by: Oleg Nesterov <> Signed-off-by: David Rientjes <> Cc: Balbir Singh <> Acked-by: KOSAKI Motohiro <> Signed-off-by: Andrew Morton <> Signed-off-by: Linus Torvalds <>
Diffstat (limited to 'mm/oom_kill.c')
1 files changed, 1 insertions, 1 deletions
diff --git a/mm/oom_kill.c b/mm/oom_kill.c
index 7c0dc414dba8..0a6e466155d2 100644
--- a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -287,7 +287,7 @@ static struct task_struct *select_bad_process(unsigned long *ppoints,
* the process of exiting and releasing its resources.
* Otherwise we could get an easy OOM deadlock.
- if (p->flags & PF_EXITING) {
+ if ((p->flags & PF_EXITING) && p->mm) {
if (p != current)
return ERR_PTR(-1UL);