path: root/net
diff options
authorVladislav Yasevich <>2005-11-11 16:05:55 -0800
committerDavid S. Miller <>2005-11-11 16:05:55 -0800
commit23ec47a0889dabf4b9e7f8d52e848194734159ee (patch)
tree1b8afadde8b3a60405163b60436897e1746084a2 /net
parent8eb55910521f3449a8125a38dd32fb676703395d (diff)
[SCTP]: Fix potential NULL pointer dereference in sctp_v4_get_saddr
It is possible to get to sctp_v4_get_saddr() without a valid association. This happens when processing OOTB packets and the cached route entry is no longer valid. However, when responding to OOTB packets we already properly set the source address based on the information in the OOTB packet. So, if we we get to sctp_v4_get_saddr() without an association we can simply return. Signed-off-by: Vladislav Yasevich <> Signed-off-by: Sridhar Samudrala <> Signed-off-by: David S. Miller <>
Diffstat (limited to 'net')
1 files changed, 3 insertions, 0 deletions
diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c
index 26de4d3e1bd9..dc9dff396fad 100644
--- a/net/sctp/protocol.c
+++ b/net/sctp/protocol.c
@@ -530,6 +530,9 @@ static void sctp_v4_get_saddr(struct sctp_association *asoc,
struct rtable *rt = (struct rtable *)dst;
+ if (!asoc)
+ return;
if (rt) {
saddr->v4.sin_family = AF_INET;
saddr->v4.sin_port = asoc->base.bind_addr.port;