diff options
author | Kent Overstreet <kent.overstreet@gmail.com> | 2022-08-10 20:28:55 -0400 |
---|---|---|
committer | Kent Overstreet <kent.overstreet@gmail.com> | 2022-08-11 17:34:34 -0400 |
commit | ddac1641ee1e2686c2211a8d671ea723634dfc89 (patch) | |
tree | 0596db2376fb5cbdcd83bf1642efdc7868ade480 /libbcachefs/ec.c | |
parent | a6128b5335a79cd68b9dbb6b083a835d94539d04 (diff) |
Update bcachefs sources to 90a9c61e2b bcachefs: Switch bch2_btree_delete_range() to bch2_trans_run()
Diffstat (limited to 'libbcachefs/ec.c')
-rw-r--r-- | libbcachefs/ec.c | 138 |
1 files changed, 58 insertions, 80 deletions
diff --git a/libbcachefs/ec.c b/libbcachefs/ec.c index 6ce352c5..f33acf1a 100644 --- a/libbcachefs/ec.c +++ b/libbcachefs/ec.c @@ -572,18 +572,14 @@ static int ec_stripe_mem_alloc(struct btree_trans *trans, struct btree_iter *iter) { size_t idx = iter->pos.offset; - int ret = 0; if (!__ec_stripe_mem_alloc(trans->c, idx, GFP_NOWAIT|__GFP_NOWARN)) - return ret; + return 0; bch2_trans_unlock(trans); - ret = -EINTR; - if (!__ec_stripe_mem_alloc(trans->c, idx, GFP_KERNEL)) - return ret; - - return -ENOMEM; + return __ec_stripe_mem_alloc(trans->c, idx, GFP_KERNEL) ?: + bch2_trans_relock(trans); } static ssize_t stripe_idx_to_delete(struct bch_fs *c) @@ -726,7 +722,7 @@ static int ec_stripe_bkey_insert(struct btree_trans *trans, struct bpos start_pos = bpos_max(min_pos, POS(0, c->ec_stripe_hint)); int ret; - for_each_btree_key(trans, iter, BTREE_ID_stripes, start_pos, + for_each_btree_key_norestart(trans, iter, BTREE_ID_stripes, start_pos, BTREE_ITER_SLOTS|BTREE_ITER_INTENT, k, ret) { if (bkey_cmp(k.k->p, POS(0, U32_MAX)) > 0) { if (start_pos.offset) { @@ -740,12 +736,13 @@ static int ec_stripe_bkey_insert(struct btree_trans *trans, } if (bkey_deleted(k.k)) - goto found_slot; + break; } - goto err; -found_slot: - start_pos = iter.pos; + c->ec_stripe_hint = iter.pos.offset; + + if (ret) + goto err; ret = ec_stripe_mem_alloc(trans, &iter); if (ret) @@ -754,8 +751,6 @@ found_slot: stripe->k.p = iter.pos; ret = bch2_trans_update(trans, &iter, &stripe->k_i, 0); - - c->ec_stripe_hint = start_pos.offset; err: bch2_trans_iter_exit(trans, &iter); @@ -822,80 +817,62 @@ static void extent_stripe_ptr_add(struct bkey_s_extent e, }; } -static int ec_stripe_update_ptrs(struct bch_fs *c, - struct ec_stripe_buf *s, - struct bkey *pos) +static int ec_stripe_update_extent(struct btree_trans *trans, + struct btree_iter *iter, + struct bkey_s_c k, + struct ec_stripe_buf *s, + struct bpos end) { - struct btree_trans trans; - struct btree_iter iter; - struct bkey_s_c k; - struct bkey_s_extent e; - struct bkey_buf sk; - struct bpos next_pos; - int ret = 0, dev, block; - - bch2_bkey_buf_init(&sk); - bch2_trans_init(&trans, c, BTREE_ITER_MAX, 0); - - /* XXX this doesn't support the reflink btree */ - - bch2_trans_iter_init(&trans, &iter, BTREE_ID_extents, - bkey_start_pos(pos), - BTREE_ITER_INTENT); -retry: - while (bch2_trans_begin(&trans), - (k = bch2_btree_iter_peek(&iter)).k && - !(ret = bkey_err(k)) && - bkey_cmp(bkey_start_pos(k.k), pos->p) < 0) { - const struct bch_extent_ptr *ptr_c; - struct bch_extent_ptr *ptr, *ec_ptr = NULL; - - if (extent_has_stripe_ptr(k, s->key.k.p.offset)) { - bch2_btree_iter_advance(&iter); - continue; - } + const struct bch_extent_ptr *ptr_c; + struct bch_extent_ptr *ptr, *ec_ptr = NULL; + struct bkey_i *n; + int ret, dev, block; - ptr_c = bkey_matches_stripe(&s->key.v, k, &block); - /* - * It doesn't generally make sense to erasure code cached ptrs: - * XXX: should we be incrementing a counter? - */ - if (!ptr_c || ptr_c->cached) { - bch2_btree_iter_advance(&iter); - continue; - } + if (bkey_cmp(bkey_start_pos(k.k), end) >= 0) + return 1; - dev = s->key.v.ptrs[block].dev; + if (extent_has_stripe_ptr(k, s->key.k.p.offset)) + return 0; - bch2_bkey_buf_reassemble(&sk, c, k); - e = bkey_i_to_s_extent(sk.k); + ptr_c = bkey_matches_stripe(&s->key.v, k, &block); + /* + * It doesn't generally make sense to erasure code cached ptrs: + * XXX: should we be incrementing a counter? + */ + if (!ptr_c || ptr_c->cached) + return 0; - bch2_bkey_drop_ptrs(e.s, ptr, ptr->dev != dev); - ec_ptr = (void *) bch2_bkey_has_device(e.s_c, dev); - BUG_ON(!ec_ptr); + dev = s->key.v.ptrs[block].dev; - extent_stripe_ptr_add(e, s, ec_ptr, block); + n = bch2_trans_kmalloc(trans, bkey_bytes(k.k)); + ret = PTR_ERR_OR_ZERO(n); + if (ret) + return ret; - bch2_btree_iter_set_pos(&iter, bkey_start_pos(&sk.k->k)); - next_pos = sk.k->k.p; + bkey_reassemble(n, k); - ret = bch2_btree_iter_traverse(&iter) ?: - bch2_trans_update(&trans, &iter, sk.k, 0) ?: - bch2_trans_commit(&trans, NULL, NULL, - BTREE_INSERT_NOFAIL); - if (!ret) - bch2_btree_iter_set_pos(&iter, next_pos); - if (ret) - break; - } - if (ret == -EINTR) - goto retry; - bch2_trans_iter_exit(&trans, &iter); + bch2_bkey_drop_ptrs(bkey_i_to_s(n), ptr, ptr->dev != dev); + ec_ptr = (void *) bch2_bkey_has_device(bkey_i_to_s_c(n), dev); + BUG_ON(!ec_ptr); - bch2_trans_exit(&trans); - bch2_bkey_buf_exit(&sk, c); + extent_stripe_ptr_add(bkey_i_to_s_extent(n), s, ec_ptr, block); - return ret; + return bch2_trans_update(trans, iter, n, 0); +} + +static int ec_stripe_update_extents(struct bch_fs *c, + struct ec_stripe_buf *s, + struct bkey *pos) +{ + struct btree_iter iter; + struct bkey_s_c k; + + return bch2_trans_run(c, + for_each_btree_key_commit(&trans, iter, + BTREE_ID_extents, bkey_start_pos(pos), + BTREE_ITER_NOT_EXTENTS|BTREE_ITER_INTENT, k, + NULL, NULL, BTREE_INSERT_NOFAIL, + ec_stripe_update_extent(&trans, &iter, k, s, pos->p))); } /* @@ -966,9 +943,10 @@ static void ec_stripe_create(struct ec_stripe_new *s) } for_each_keylist_key(&s->keys, k) { - ret = ec_stripe_update_ptrs(c, &s->new_stripe, &k->k); + ret = ec_stripe_update_extents(c, &s->new_stripe, &k->k); if (ret) { - bch_err(c, "error creating stripe: error %i updating pointers", ret); + bch_err(c, "error creating stripe: error updating pointers: %s", + bch2_err_str(ret)); break; } } |