diff options
author | Kent Overstreet <kent.overstreet@gmail.com> | 2019-03-24 21:06:58 -0400 |
---|---|---|
committer | Kent Overstreet <kent.overstreet@gmail.com> | 2019-03-24 21:06:58 -0400 |
commit | ddb58076ef4fe4572ab8537785fc67052f47bf5b (patch) | |
tree | 57e0c770dab82d9cf7bb02e40dd1126701657958 /libbcachefs/migrate.c | |
parent | 0894d547501fb9306ae7b1c669b66a7b49fb2205 (diff) |
Update bcachefs sources to ffe09df106 bcachefs: Verify fs hasn't been modified before going rw
Diffstat (limited to 'libbcachefs/migrate.c')
-rw-r--r-- | libbcachefs/migrate.c | 28 |
1 files changed, 17 insertions, 11 deletions
diff --git a/libbcachefs/migrate.c b/libbcachefs/migrate.c index bb425d88..58d7d3a3 100644 --- a/libbcachefs/migrate.c +++ b/libbcachefs/migrate.c @@ -35,25 +35,29 @@ static int drop_dev_ptrs(struct bch_fs *c, struct bkey_s k, static int bch2_dev_usrdata_drop(struct bch_fs *c, unsigned dev_idx, int flags) { + struct btree_trans trans; + struct btree_iter *iter; struct bkey_s_c k; BKEY_PADDED(key) tmp; - struct btree_iter iter; int ret = 0; + bch2_trans_init(&trans, c); + + iter = bch2_trans_get_iter(&trans, BTREE_ID_EXTENTS, + POS_MIN, BTREE_ITER_PREFETCH); + mutex_lock(&c->replicas_gc_lock); bch2_replicas_gc_start(c, (1 << BCH_DATA_USER)|(1 << BCH_DATA_CACHED)); - bch2_btree_iter_init(&iter, c, BTREE_ID_EXTENTS, - POS_MIN, BTREE_ITER_PREFETCH); - while ((k = bch2_btree_iter_peek(&iter)).k && + while ((k = bch2_btree_iter_peek(iter)).k && !(ret = btree_iter_err(k))) { if (!bkey_extent_is_data(k.k) || !bch2_extent_has_device(bkey_s_c_to_extent(k), dev_idx)) { ret = bch2_mark_bkey_replicas(c, k); if (ret) break; - bch2_btree_iter_next(&iter); + bch2_btree_iter_next(iter); continue; } @@ -71,12 +75,14 @@ static int bch2_dev_usrdata_drop(struct bch_fs *c, unsigned dev_idx, int flags) */ bch2_extent_normalize(c, bkey_i_to_s(&tmp.key)); - iter.pos = bkey_start_pos(&tmp.key.k); + /* XXX not sketchy at all */ + iter->pos = bkey_start_pos(&tmp.key.k); - ret = bch2_btree_insert_at(c, NULL, NULL, - BTREE_INSERT_ATOMIC| - BTREE_INSERT_NOFAIL, - BTREE_INSERT_ENTRY(&iter, &tmp.key)); + bch2_trans_update(&trans, BTREE_INSERT_ENTRY(iter, &tmp.key)); + + ret = bch2_trans_commit(&trans, NULL, NULL, + BTREE_INSERT_ATOMIC| + BTREE_INSERT_NOFAIL); /* * don't want to leave ret == -EINTR, since if we raced and @@ -89,7 +95,7 @@ static int bch2_dev_usrdata_drop(struct bch_fs *c, unsigned dev_idx, int flags) break; } - bch2_btree_iter_unlock(&iter); + bch2_trans_exit(&trans); bch2_replicas_gc_end(c, ret); mutex_unlock(&c->replicas_gc_lock); |