diff options
| author | Florian Fainelli <f.fainelli@gmail.com> | 2015-07-11 18:02:11 -0700 |
|---|---|---|
| committer | Luis Henriques <luis.henriques@canonical.com> | 2015-08-10 17:10:19 +0100 |
| commit | 0e1b541ba2e8c13a0711d62d21eaea2b1aed869f (patch) | |
| tree | 78a298c8d7a840c88c71daa6e09502938b41fda0 | |
| parent | a72eb546da6f95d5043f4731f8e9ae7476f14322 (diff) | |
net: dsa: Fix off-by-one in switch address parsing
commit c8cf89f73f3d9ecbdea479778f0ac714be79be33 upstream.
cd->sw_addr is used as a MDIO bus address, which cannot exceed
PHY_MAX_ADDR (32), our check was off-by-one.
Fixes: 5e95329b701c ("dsa: add device tree bindings to register DSA switches")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
| -rw-r--r-- | net/dsa/dsa.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c index d3ca32dc167f..a3c70870448f 100644 --- a/net/dsa/dsa.c +++ b/net/dsa/dsa.c @@ -418,7 +418,7 @@ static int dsa_of_probe(struct platform_device *pdev) continue; cd->sw_addr = be32_to_cpup(sw_addr); - if (cd->sw_addr > PHY_MAX_ADDR) + if (cd->sw_addr >= PHY_MAX_ADDR) continue; for_each_available_child_of_node(child, port) { |