diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2025-01-07 16:35:19 +0300 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2025-01-10 18:18:46 -0500 |
| commit | 17789f8a5b81356fc83cf20de899fc351679574e (patch) | |
| tree | 9f03a1107c724cc809ce94bb1d3a314d7ac4f28b | |
| parent | bab8551e33f7f5e8743ccb49be41fe3228178e8a (diff) | |
scsi: fnic: Delete incorrect debugfs error handling
Debugfs functions are not supposed to require error checking and, in fact,
adding checks would normally lead to the driver refusing to load when
CONFIG_DEBUGFS is disabled.
What saves us here is that this code checks for NULL instead of error
pointers so the error checking is all dead code. Delete it.
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/a5c237cd-449b-4f9d-bcff-6285fb7c28d1@stanley.mountain
Reviewed-by: Karan Tilak Kumar <kartilak@cisco.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
| -rw-r--r-- | drivers/scsi/fnic/fnic_debugfs.c | 25 |
1 files changed, 1 insertions, 24 deletions
diff --git a/drivers/scsi/fnic/fnic_debugfs.c b/drivers/scsi/fnic/fnic_debugfs.c index caee32bc9190..5767862ae42f 100644 --- a/drivers/scsi/fnic/fnic_debugfs.c +++ b/drivers/scsi/fnic/fnic_debugfs.c @@ -679,46 +679,23 @@ static const struct file_operations fnic_reset_debugfs_fops = { */ int fnic_stats_debugfs_init(struct fnic *fnic) { - int rc = -1; char name[16]; snprintf(name, sizeof(name), "host%d", fnic->host->host_no); - if (!fnic_stats_debugfs_root) { - pr_debug("fnic_stats root doesn't exist\n"); - return rc; - } - fnic->fnic_stats_debugfs_host = debugfs_create_dir(name, fnic_stats_debugfs_root); - - if (!fnic->fnic_stats_debugfs_host) { - pr_debug("Cannot create host directory\n"); - return rc; - } - fnic->fnic_stats_debugfs_file = debugfs_create_file("stats", S_IFREG|S_IRUGO|S_IWUSR, fnic->fnic_stats_debugfs_host, fnic, &fnic_stats_debugfs_fops); - - if (!fnic->fnic_stats_debugfs_file) { - pr_debug("Cannot create host stats file\n"); - return rc; - } - fnic->fnic_reset_debugfs_file = debugfs_create_file("reset_stats", S_IFREG|S_IRUGO|S_IWUSR, fnic->fnic_stats_debugfs_host, fnic, &fnic_reset_debugfs_fops); - if (!fnic->fnic_reset_debugfs_file) { - pr_debug("Cannot create host stats file\n"); - return rc; - } - rc = 0; - return rc; + return 0; } /* |