diff options
| author | Gao Xiang <hsiangkao@linux.alibaba.com> | 2025-05-22 16:49:53 +0800 |
|---|---|---|
| committer | Gao Xiang <hsiangkao@linux.alibaba.com> | 2025-05-23 07:51:14 +0800 |
| commit | 17a2a72df3b632a14c25b4e3117deb57860b548c (patch) | |
| tree | 7b2eec123c40f242962113cd643dd26a7601d04b | |
| parent | c36ec00d7f67590cb03e233959cd92fe969753a3 (diff) | |
erofs: clean up erofs_{init,exit}_sysfs()
Get rid of useless `goto`s. No logic changes.
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Link: https://lore.kernel.org/r/20250522084953.412096-1-hsiangkao@linux.alibaba.com
| -rw-r--r-- | fs/erofs/sysfs.c | 32 |
1 files changed, 13 insertions, 19 deletions
diff --git a/fs/erofs/sysfs.c b/fs/erofs/sysfs.c index dad4e6c6c155..c6650350c4cd 100644 --- a/fs/erofs/sysfs.c +++ b/fs/erofs/sysfs.c @@ -248,6 +248,12 @@ void erofs_unregister_sysfs(struct super_block *sb) } } +void erofs_exit_sysfs(void) +{ + kobject_put(&erofs_feat); + kset_unregister(&erofs_root); +} + int __init erofs_init_sysfs(void) { int ret; @@ -255,24 +261,12 @@ int __init erofs_init_sysfs(void) kobject_set_name(&erofs_root.kobj, "erofs"); erofs_root.kobj.parent = fs_kobj; ret = kset_register(&erofs_root); - if (ret) - goto root_err; - - ret = kobject_init_and_add(&erofs_feat, &erofs_feat_ktype, - NULL, "features"); - if (ret) - goto feat_err; - return ret; - -feat_err: - kobject_put(&erofs_feat); - kset_unregister(&erofs_root); -root_err: + if (!ret) { + ret = kobject_init_and_add(&erofs_feat, &erofs_feat_ktype, + NULL, "features"); + if (!ret) + return 0; + erofs_exit_sysfs(); + } return ret; } - -void erofs_exit_sysfs(void) -{ - kobject_put(&erofs_feat); - kset_unregister(&erofs_root); -} |