diff options
| author | Willem de Bruijn <willemb@google.com> | 2016-03-09 21:58:33 -0500 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2016-05-01 00:06:13 +0200 |
| commit | 2b432a04a74a6bd338a877bac79f4f5e90d1a57c (patch) | |
| tree | dd375ed61772f5a2af516762706335f27ed4ddd5 | |
| parent | a534cb3d4db0c16e95236225e70fd7c89b95a4f5 (diff) | |
ax25: add link layer header validation function
commit ea47781c26510e5d97f80f9aceafe9065bd5e3aa upstream.
As variable length protocol, AX25 fails link layer header validation
tests based on a minimum length. header_ops.validate allows protocols
to validate headers that are shorter than hard_header_len. Implement
this callback for AX25.
See also http://comments.gmane.org/gmane.linux.network/401064
Signed-off-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
[bwh: Backported to 3.16: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
| -rw-r--r-- | net/ax25/ax25_ip.c | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/net/ax25/ax25_ip.c b/net/ax25/ax25_ip.c index 67de6b33f2c3..5ee8c6fc1a75 100644 --- a/net/ax25/ax25_ip.c +++ b/net/ax25/ax25_ip.c @@ -231,9 +231,24 @@ int ax25_rebuild_header(struct sk_buff *skb) #endif +static bool ax25_validate_header(const char *header, unsigned int len) +{ + ax25_digi digi; + + if (!len) + return false; + + if (header[0]) + return true; + + return ax25_addr_parse(header + 1, len - 1, NULL, NULL, &digi, NULL, + NULL); +} + const struct header_ops ax25_header_ops = { .create = ax25_hard_header, .rebuild = ax25_rebuild_header, + .validate = ax25_validate_header, }; EXPORT_SYMBOL(ax25_hard_header); |