diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2023-04-13 21:35:36 +0200 |
|---|---|---|
| committer | Helge Deller <deller@gmx.de> | 2025-03-26 22:39:20 +0100 |
| commit | 2df2c0caaecfd869b49e14f2b8df822397c5dd7f (patch) | |
| tree | 66a74736a21822c0cefbbd99def04830f970d1a6 | |
| parent | b347f4571e9f3d5b0ea719aeec1af4d500c1507f (diff) | |
fbdev: au1100fb: Move a variable assignment behind a null pointer check
The address of a data structure member was determined before
a corresponding null pointer check in the implementation of
the function “au1100fb_setmode”.
This issue was detected by using the Coccinelle software.
Fixes: 3b495f2bb749 ("Au1100 FB driver uplift for 2.6.")
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Signed-off-by: Helge Deller <deller@gmx.de>
| -rw-r--r-- | drivers/video/fbdev/au1100fb.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/video/fbdev/au1100fb.c b/drivers/video/fbdev/au1100fb.c index 840f22160763..6251a6b07b3a 100644 --- a/drivers/video/fbdev/au1100fb.c +++ b/drivers/video/fbdev/au1100fb.c @@ -137,13 +137,15 @@ static int au1100fb_fb_blank(int blank_mode, struct fb_info *fbi) */ int au1100fb_setmode(struct au1100fb_device *fbdev) { - struct fb_info *info = &fbdev->info; + struct fb_info *info; u32 words; int index; if (!fbdev) return -EINVAL; + info = &fbdev->info; + /* Update var-dependent FB info */ if (panel_is_active(fbdev->panel) || panel_is_color(fbdev->panel)) { if (info->var.bits_per_pixel <= 8) { |