summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorQasim Ijaz <qasdev00@gmail.com>2025-03-13 21:45:45 +0000
committerMark Brown <broonie@kernel.org>2025-03-16 23:34:24 +0000
commit3c9403f150b70d76198e414d53c95e1698e3f99f (patch)
treea1764589cc4863095fb25b2ebcf47658ec7061e2
parent336a41c90c86b883aa06ed19f138eee19ddf9958 (diff)
spi: sophgo: fix incorrect type for ret in sg2044_spifmc_write()
The sg2044_spifmc_write() function uses 'ret' of unsigned type size_t to capture return values from sg2044_spifmc_wait_xfer_size() and sg2044_spifmc_wait_int(). Since these functions may return negative error codes, using an unsigned type prevents proper error detection, as size_t cannot represent negative values. Change 'ret' to type int so that negative values are handled correctly. Fixes: de16c322eefb ("spi: sophgo: add SG2044 SPI NOR controller driver") Signed-off-by: Qasim Ijaz <qasdev00@gmail.com> Link: https://patch.msgid.link/20250313214545.7444-1-qasdev00@gmail.com Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r--drivers/spi/spi-sg2044-nor.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/spi/spi-sg2044-nor.c b/drivers/spi/spi-sg2044-nor.c
index 454153a63b42..baa4cf677663 100644
--- a/drivers/spi/spi-sg2044-nor.c
+++ b/drivers/spi/spi-sg2044-nor.c
@@ -216,7 +216,7 @@ static ssize_t sg2044_spifmc_write(struct sg2044_spifmc *spifmc,
size_t xfer_size;
const u8 *dout = op->data.buf.out;
int i, offset;
- size_t ret;
+ int ret;
u32 reg;
reg = sg2044_spifmc_init_reg(spifmc);