diff options
| author | Sudeep Holla <sudeep.holla@arm.com> | 2025-03-13 15:28:50 +0000 |
|---|---|---|
| committer | Jassi Brar <jassisinghbrar@gmail.com> | 2025-03-26 20:58:25 -0500 |
| commit | 4119a44c71840e6ab9a8d340ca09e7b3210ade76 (patch) | |
| tree | cb25f3535de24caa468158ffde21ee9c03db63e5 | |
| parent | 29237e6df42b08ccb4152121ec2c650fdae103e1 (diff) | |
mailbox: pcc: Return early if no GAS register from pcc_mbox_cmd_complete_check
pcc_mbox_cmd_complete_check() accesses pchan->cmd_complete.gas to check
command completion status. Even if GAS is NULL, pcc_chan_reg_read() gets
called which returns success doing nothing and then we return.
Add an early return if pchan->cmd_complete.gas == NULL before performing
any operations.
Acked-by: Huisong Li <lihuisong@huawei.com>
Tested-by: Huisong Li <lihuisong@huawei.com>
Tested-by: Adam Young <admiyo@os.amperecomputing.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
| -rw-r--r-- | drivers/mailbox/pcc.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c index 9cf0ca772c1a..7105dd6bc2fc 100644 --- a/drivers/mailbox/pcc.c +++ b/drivers/mailbox/pcc.c @@ -245,13 +245,13 @@ static bool pcc_mbox_cmd_complete_check(struct pcc_chan_info *pchan) u64 val; int ret; + if (!pchan->cmd_complete.gas) + return true; + ret = pcc_chan_reg_read(&pchan->cmd_complete, &val); if (ret) return false; - if (!pchan->cmd_complete.gas) - return true; - /* * Judge if the channel respond the interrupt based on the value of * command complete. |