summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJedrzej Jagielski <jedrzej.jagielski@intel.com>2025-04-10 14:59:54 +0200
committerTony Nguyen <anthony.l.nguyen@intel.com>2025-04-15 07:36:31 -0700
commit8982fc03fd630a38c0d0ebddef768b4d4707b659 (patch)
tree4f84c26573de7c5c416cebd30166d09b49dfe4a1
parente8a1bd8344054ce27bebf59f48e3f6bc10bc419b (diff)
devlink: add value check to devlink_info_version_put()
Prevent from proceeding if there's nothing to print. Suggested-by: Przemek Kitszel <przemyslaw.kitszel@intel.com> Reviewed-by: Jiri Pirko <jiri@nvidia.com> Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Tested-by: Bharath R <bharath.r@intel.com> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
-rw-r--r--net/devlink/dev.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/devlink/dev.c b/net/devlink/dev.c
index d6e3db300acb..02602704bdea 100644
--- a/net/devlink/dev.c
+++ b/net/devlink/dev.c
@@ -775,7 +775,7 @@ static int devlink_info_version_put(struct devlink_info_req *req, int attr,
req->version_cb(version_name, version_type,
req->version_cb_priv);
- if (!req->msg)
+ if (!req->msg || !*version_value)
return 0;
nest = nla_nest_start_noflag(req->msg, attr);