summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVille Syrjälä <ville.syrjala@linux.intel.com>2024-05-02 15:14:21 +0300
committerVille Syrjälä <ville.syrjala@linux.intel.com>2024-05-08 14:22:34 +0300
commit8b69ac66d68907deb473b310b4f2c2a6b26ef191 (patch)
treeb1a4bafefdb432c47dc9ec66bd617f9ebddf83d5
parent749670a58d935303ad1ce529acc73f12de25832e (diff)
drm/i915: Fix HAS_REGION() usage in intel_gt_probe_lmem()
HAS_REGION() takes a bitmask, not the region ID. This causes the GEM_BUG_ON() to assert that the SMEM region is available rather than the intended LMEM region. No real harm since SMEM is always available, but also not checking what was intended. Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240502121423.1002-1-ville.syrjala@linux.intel.com Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
-rw-r--r--drivers/gpu/drm/i915/gt/intel_gt.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c
index 45920cda0cc7..96b444905d8c 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt.c
@@ -105,7 +105,7 @@ static int intel_gt_probe_lmem(struct intel_gt *gt)
intel_memory_region_set_name(mem, "local%u", mem->instance);
- GEM_BUG_ON(!HAS_REGION(i915, id));
+ GEM_BUG_ON(!HAS_REGION(i915, BIT(id)));
GEM_BUG_ON(i915->mm.regions[id]);
i915->mm.regions[id] = mem;