summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCengiz Can <cengiz@kernel.wtf>2020-08-31 15:51:04 +0200
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>2020-09-22 10:04:04 +0200
commit9ce5fe9584db7d8c5c09930b4fa3fa6569d7815d (patch)
treeca1dd80aff8bc2658dd74dbd6a2f95f02a4ea9c2
parent2394984fee7356e8c03817316cff4e9b7896fbb4 (diff)
media: staging: atomisp: Remove unnecessary 'fallthrough'
commit df561f6688fe ("treewide: Use fallthrough pseudo-keyword") from Gustavo A. R. Silva replaced and standardized /* fallthrough */ comments with 'fallthrough' pseudo-keyword. However, in one of the switch-case statements, Coverity Static Analyzer throws a warning that 'fallthrough' is unreachable due to the adjacent 'return false' statement. (Coverity ID CID 1466511) In order to fix the unreachable code warning, remove unnecessary fallthrough keyword. Signed-off-by: Cengiz Can <cengiz@kernel.wtf> Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
-rw-r--r--drivers/staging/media/atomisp/pci/atomisp_compat_css20.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c b/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c
index a78c53251346..28796ec177e3 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c
@@ -700,7 +700,6 @@ static bool is_pipe_valid_to_current_run_mode(struct atomisp_sub_device *asd,
return true;
return false;
- fallthrough;
case ATOMISP_RUN_MODE_VIDEO:
if (!asd->continuous_mode->val) {
if (pipe_id == IA_CSS_PIPE_ID_VIDEO ||