summaryrefslogtreecommitdiff
path: root/arch
diff options
context:
space:
mode:
authorTom Rix <trix@redhat.com>2020-09-13 09:52:30 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-10-01 13:12:51 +0200
commit9c3c9d37ae1e430a2a31edfcd4c518125547223c (patch)
tree5cbfdba0dec08e13248ec58731dbd1476aeb0f3e /arch
parent8413d9717513f828e38f69895c1b4f5d3e82f1a2 (diff)
ALSA: asihpi: fix iounmap in error handler
[ Upstream commit 472eb39103e885f302fd8fd6eff104fcf5503f1b ] clang static analysis flags this problem hpioctl.c:513:7: warning: Branch condition evaluates to a garbage value if (pci.ap_mem_base[idx]) { ^~~~~~~~~~~~~~~~~~~~ If there is a failure in the middle of the memory space loop, only some of the memory spaces need to be cleaned up. At the error handler, idx holds the number of successful memory spaces mapped. So rework the handler loop to use the old idx. There is a second problem, the memory space loop conditionally iomaps()/sets the mem_base so it is necessay to initize pci. Fixes: 719f82d3987a ("ALSA: Add support of AudioScience ASI boards") Signed-off-by: Tom Rix <trix@redhat.com> Link: https://lore.kernel.org/r/20200913165230.17166-1-trix@redhat.com Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'arch')
0 files changed, 0 insertions, 0 deletions