diff options
| author | Thomas Zimmermann <tzimmermann@suse.de> | 2025-07-06 18:26:42 +0200 |
|---|---|---|
| committer | Thomas Zimmermann <tzimmermann@suse.de> | 2025-07-09 14:36:21 +0200 |
| commit | eb104c69db707ce0208f753a897dadd39f51342f (patch) | |
| tree | 62ccac24b63aa647958d376fe1f9fb2f90d680e4 /drivers/gpu/drm/ast/ast_2000.c | |
| parent | f28f15e6d009c029a28eebc10944362346e34554 (diff) | |
drm/ast: Handle known struct ast_dramstruct with helpers
Most of struct ast_dramstruct stores hardware state. Some index
values have known or special meaning. The known values are
- 0xffff - Terminal entry in the array
- 0xff00 - Delays the programming for usecs
- 0x0004 - Sets the type of DRAM
Add constants and helper macros for these cases. Also add a helper
macro for testing. Update Gen1 and Gen2+ accordingly.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
Link: https://lore.kernel.org/r/20250706162816.211552-8-tzimmermann@suse.de
Diffstat (limited to 'drivers/gpu/drm/ast/ast_2000.c')
| -rw-r--r-- | drivers/gpu/drm/ast/ast_2000.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/drivers/gpu/drm/ast/ast_2000.c b/drivers/gpu/drm/ast/ast_2000.c index b2ad2ea5056b..93f13ecc74dc 100644 --- a/drivers/gpu/drm/ast/ast_2000.c +++ b/drivers/gpu/drm/ast/ast_2000.c @@ -38,9 +38,9 @@ static const struct ast_dramstruct ast2000_dram_table_data[] = { { 0x0108, 0x00000000 }, { 0x0120, 0x00004a21 }, - { 0xFF00, 0x00000043 }, + AST_DRAMSTRUCT_UDELAY(67u), { 0x0000, 0xFFFFFFFF }, - { 0x0004, 0x00000089 }, + AST_DRAMSTRUCT_INIT(DRAM_TYPE, 0x00000089), { 0x0008, 0x22331353 }, { 0x000C, 0x0d07000b }, { 0x0010, 0x11113333 }, @@ -49,18 +49,18 @@ static const struct ast_dramstruct ast2000_dram_table_data[] = { { 0x0024, 0x00000001 }, { 0x001C, 0x00000000 }, { 0x0014, 0x00000003 }, - { 0xFF00, 0x00000043 }, + AST_DRAMSTRUCT_UDELAY(67u), { 0x0018, 0x00000131 }, { 0x0014, 0x00000001 }, - { 0xFF00, 0x00000043 }, + AST_DRAMSTRUCT_UDELAY(67u), { 0x0018, 0x00000031 }, { 0x0014, 0x00000001 }, - { 0xFF00, 0x00000043 }, + AST_DRAMSTRUCT_UDELAY(67u), { 0x0028, 0x1e0828f1 }, { 0x0024, 0x00000003 }, { 0x002C, 0x1f0f28fb }, { 0x0030, 0xFFFFFE01 }, - { 0xFFFF, 0xFFFFFFFF } + AST_DRAMSTRUCT_INVALID, }; static void ast_post_chip_2000(struct ast_device *ast) @@ -81,8 +81,8 @@ static void ast_post_chip_2000(struct ast_device *ast) ; } while (ast_read32(ast, 0x10100) != 0xa8); - while (dram_reg_info->index != 0xffff) { - if (dram_reg_info->index == 0xff00) {/* delay fn */ + while (!AST_DRAMSTRUCT_IS(dram_reg_info, INVALID)) { + if (AST_DRAMSTRUCT_IS(dram_reg_info, UDELAY)) { for (i = 0; i < 15; i++) udelay(dram_reg_info->data); } else { |