diff options
| author | Subramaniam C.A <subramaniam.ca@ti.com> | 2010-05-06 14:52:10 -0500 |
|---|---|---|
| committer | Hari Kanigeri <h-kanigeri2@ti.com> | 2010-07-09 17:56:18 -0500 |
| commit | 9688fed35a3507e8d8962f2659861acae54b7e69 (patch) | |
| tree | b23bde5436f879d736e1304e98f2697062a7fee3 /drivers | |
| parent | 8bd89cfb4856b50c61a63c186244a19d8d12872a (diff) | |
SYSLINK: Proc4430 module KW defect fixed for release 24.6
Defect:
'hw_attrs.element_size' might be used uninitialized in this function.
hw_attrs is passed to the following function, and if the
hw_attrs.mixedSize is set to 1 then element_size is not initialised.
status = pte_set(pa, da, HW_PAGE_SIZE_4KB, &hw_attrs);
TRM says if mixedSize is supported, then element_size can be ignored.
set element_size to 3 (no conversion).
Signed-off-by: Hari Kanigeri <h-kanigeri2@ti.com>
Signed-off-by: Ramesh Gupta G <grgupta@ti.com>
Signed-off-by: Suman Anna <s-anna@ti.com>
Signed-off-by: Subramaniam C.A <subramaniam.ca@ti.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/dsp/syslink/procmgr/proc4430/ducatienabler.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/dsp/syslink/procmgr/proc4430/ducatienabler.c b/drivers/dsp/syslink/procmgr/proc4430/ducatienabler.c index ad87016301f1..9c1403f929a1 100644 --- a/drivers/dsp/syslink/procmgr/proc4430/ducatienabler.c +++ b/drivers/dsp/syslink/procmgr/proc4430/ducatienabler.c @@ -400,6 +400,10 @@ int ducati_mem_map(u32 mpu_addr, u32 ul_virt_addr, DPRINTK("WMD_BRD_MemMap: MMU element size is zero\n"); return -EINVAL; } + } else { + /* If mixedSize set to 1, no conversion is + * required. for element size */ + hw_attrs.element_size = HW_ELEM_SIZE_64BIT; } /* * Do OS-specific user-va to pa translation. |