summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorAndi Shyti <andi@etezian.org>2014-01-30 00:05:01 -0300
committerMauro Carvalho Chehab <m.chehab@samsung.com>2014-02-04 06:35:26 -0200
commit62fd0d30e1fbd12d5a07ff722b2726bb8fa630c7 (patch)
tree907d3962ed4cf3d0d0a9c5e1661a56ce6ee9a421 /drivers
parent08e10972661db78d0e0a2d4a4c28fc3bf93617ba (diff)
[media] cx24117: remove dead code in always 'false' if statement
At this point of the execution in the function cx24117_attach() demod cannot be '0'. In that case the function returns earlier with an error value ('NULL'). Remove the if statement. This error has been reported by scan.coverity.com Signed-off-by: Andi Shyti <andi@etezian.org> Signed-off-by: Michael Krufky <mkrufky@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/media/dvb-frontends/cx24117.c8
1 files changed, 0 insertions, 8 deletions
diff --git a/drivers/media/dvb-frontends/cx24117.c b/drivers/media/dvb-frontends/cx24117.c
index 68f768a5422d..782dcfe6ae69 100644
--- a/drivers/media/dvb-frontends/cx24117.c
+++ b/drivers/media/dvb-frontends/cx24117.c
@@ -1200,12 +1200,6 @@ struct dvb_frontend *cx24117_attach(const struct cx24117_config *config,
state->demod = demod - 1;
state->priv = priv;
- /* test i2c bus for ack */
- if (demod == 0) {
- if (cx24117_readreg(state, 0x00) < 0)
- goto error3;
- }
-
dev_info(&state->priv->i2c->dev,
"%s: Attaching frontend %d\n",
KBUILD_MODNAME, state->demod);
@@ -1216,8 +1210,6 @@ struct dvb_frontend *cx24117_attach(const struct cx24117_config *config,
state->frontend.demodulator_priv = state;
return &state->frontend;
-error3:
- kfree(state);
error2:
cx24117_release_priv(priv);
error1: