summaryrefslogtreecommitdiff
path: root/fs/xfs/libxfs/xfs_rmap.h
diff options
context:
space:
mode:
authorDarrick J. Wong <djwong@kernel.org>2023-02-10 09:06:06 -0800
committerDarrick J. Wong <djwong@kernel.org>2023-02-10 09:06:06 -0800
commitdd07bb8b6baf2389caff221f043d9188ce6bab8c (patch)
treefd1206f2a1e7849ea19b68eef376a2f03c71d504 /fs/xfs/libxfs/xfs_rmap.h
parent2ee8333529857a702475ce36d3af3ecbbcf5af5a (diff)
xfs: revert commit 8954c44ff477xfs-6.3-merge-2
The name passed into __xfs_xattr_put_listent is exactly namelen bytes long and not null-terminated. Passing namelen+1 to the strscpy function strscpy(offset, (char *)name, namelen + 1); is therefore wrong. Go back to the old code, which works fine because strncpy won't find a null in @name and stops after namelen bytes. It really could be a memcpy call, but it worked for years. Reported-by: syzbot+898115bc6d7140437215@syzkaller.appspotmail.com Fixes: 8954c44ff477 ("xfs: use strscpy() to instead of strncpy()") Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Diffstat (limited to 'fs/xfs/libxfs/xfs_rmap.h')
0 files changed, 0 insertions, 0 deletions