diff options
| author | Tejun Heo <tj@kernel.org> | 2025-05-14 11:11:48 -0400 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2025-05-14 11:11:48 -0400 |
| commit | d310fb40096896abe1928b88224129bf7122532f (patch) | |
| tree | 50abded3520e611ca25a5025bc882ce35e1b99c0 /kernel/sched/ext_idle.c | |
| parent | 051398f52b7cb0dbeda8da355b948fad3d23cb0f (diff) | |
sched_ext: Clean up scx_root usages
- Always cache scx_root into local variable sch before using.
- Don't use scx_root if cached sch is available.
- Wrap !sch test with unlikely().
- Pass @scx into scx_cgroup_init/exit().
No behavior changes intended.
Signed-off-by: Tejun Heo <tj@kernel.org>
Reviewed-by: Andrea Righi <arighi@nvidia.com>
Diffstat (limited to 'kernel/sched/ext_idle.c')
| -rw-r--r-- | kernel/sched/ext_idle.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/kernel/sched/ext_idle.c b/kernel/sched/ext_idle.c index 6915685cd3d6..0a116bcd681b 100644 --- a/kernel/sched/ext_idle.c +++ b/kernel/sched/ext_idle.c @@ -733,6 +733,7 @@ static void update_builtin_idle(int cpu, bool idle) */ void __scx_update_idle(struct rq *rq, bool idle, bool do_notify) { + struct scx_sched *sch = scx_root; int cpu = cpu_of(rq); lockdep_assert_rq_held(rq); @@ -744,8 +745,7 @@ void __scx_update_idle(struct rq *rq, bool idle, bool do_notify) * Idle transitions are indicated by do_notify being set to true, * managed by put_prev_task_idle()/set_next_task_idle(). */ - if (SCX_HAS_OP(scx_root, update_idle) && - do_notify && !scx_rq_bypassing(rq)) + if (SCX_HAS_OP(sch, update_idle) && do_notify && !scx_rq_bypassing(rq)) SCX_CALL_OP(SCX_KF_REST, update_idle, rq, cpu_of(rq), idle); /* |