diff options
author | Eric Dumazet <edumazet@google.com> | 2024-12-04 21:02:34 +0000 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2024-12-06 17:41:28 -0800 |
commit | 6c36b5c244d6cb22ef8ea2f6b5da46f5171b37a5 (patch) | |
tree | 1c7080d24f60e962449a686aca092b0e1b22467f /net/tipc/netlink.c | |
parent | e36d46b9af682bac7c376638cf0fd98d18b98653 (diff) |
net: tipc: remove one synchronize_net() from tipc_nametbl_stop()
tipc_exit_net() is very slow and is abused by syzbot.
tipc_nametbl_stop() is called for each netns being dismantled.
Calling synchronize_net() right before freeing tn->nametbl
is a big hammer.
Replace this with kfree_rcu().
Note that RCU is not properly used here, otherwise
tn->nametbl should be cleared before the synchronize_net()
or kfree_rcu(), or even before the cleanup loop.
We might need to fix this at some point.
Also note tipc uses other synchronize_rcu() calls,
more work is needed to make tipc_exit_net() much faster.
List of remaining calls to synchronize_rcu()
tipc_detach_loopback() (dev_remove_pack())
tipc_bcast_stop()
tipc_sk_rht_destroy()
Signed-off-by: Eric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20241204210234.319484-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/tipc/netlink.c')
0 files changed, 0 insertions, 0 deletions