diff options
| author | Andrew Morton <akpm@linux-foundation.org> | 2013-02-07 12:27:17 +1100 |
|---|---|---|
| committer | Stephen Rothwell <sfr@canb.auug.org.au> | 2013-02-07 16:39:04 +1100 |
| commit | ee5792d24a4ecf9876e688adaac6eecabbef71d9 (patch) | |
| tree | 4afe474ab62d1f029fb7e5b7bb5de8db57048787 /scripts | |
| parent | 7f299d366801f1d6b3a8aedadd2ca0f2cb44e349 (diff) | |
scripts-pnmtologo-fix-for-plain-pbm-checkpatch-fixes
ERROR: do not initialise statics to 0 or NULL
#24: FILE: scripts/pnmtologo.c:77:
+static int is_plain_pbm = 0;
WARNING: line over 80 characters
#33: FILE: scripts/pnmtologo.c:108:
+ * between the digits. This is Ok cause we know a PBM can only have a '1'
total: 1 errors, 1 warnings, 25 lines checked
./patches/scripts-pnmtologo-fix-for-plain-pbm.patch has style problems, please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Please run checkpatch prior to sending patches
Cc: Andreas Bießmann <andreas@biessmann.de>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'scripts')
| -rw-r--r-- | scripts/pnmtologo.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/scripts/pnmtologo.c b/scripts/pnmtologo.c index 68bb4efc5af4..ce937970cf98 100644 --- a/scripts/pnmtologo.c +++ b/scripts/pnmtologo.c @@ -104,9 +104,11 @@ static unsigned int get_number(FILE *fp) val = 0; while (isdigit(c)) { val = 10*val+c-'0'; - /* some PBM are 'broken'; GiMP for example exports a PBM without space - * between the digits. This is Ok cause we know a PBM can only have a '1' - * or a '0' for the digit. */ + /* + * Some PBM are 'broken'; GiMP for example exports a PBM without space + * between the digits. This is OK because we know a PBM can only have a + * '1' or a '0' for the digit. + */ if (is_plain_pbm) break; c = fgetc(fp); |