summaryrefslogtreecommitdiff
path: root/tools
diff options
context:
space:
mode:
authorAntonio Alvarez Feijoo <antonio.feijoo@suse.com>2023-02-22 08:27:35 +0900
committerMasami Hiramatsu (Google) <mhiramat@kernel.org>2023-02-22 08:27:35 +0900
commitcf8c59a3756b2735c409a9b3ac1e4ec556546a7a (patch)
treee1e8238626ed0bf2b5a75fa3fbb09bab73be7a3c /tools
parentc9c3395d5e3dcc6daee66c6908354d47bf98cb0c (diff)
tools/bootconfig: fix single & used for logical condition
A single & will create a background process and return true, so the grep command will run even if the file checked in the first condition does not exist. Link: https://lore.kernel.org/all/20230112114215.17103-1-antonio.feijoo@suse.com/ Fixes: 1eaad3ac3f39 ("tools/bootconfig: Use per-group/all enable option in ftrace2bconf script") Signed-off-by: Antonio Alvarez Feijoo <antonio.feijoo@suse.com> Cc: stable@vger.kernel.org Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Diffstat (limited to 'tools')
-rwxr-xr-xtools/bootconfig/scripts/ftrace2bconf.sh2
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/bootconfig/scripts/ftrace2bconf.sh b/tools/bootconfig/scripts/ftrace2bconf.sh
index 6183b36c6846..1603801cf126 100755
--- a/tools/bootconfig/scripts/ftrace2bconf.sh
+++ b/tools/bootconfig/scripts/ftrace2bconf.sh
@@ -93,7 +93,7 @@ referred_vars() {
}
event_is_enabled() { # enable-file
- test -f $1 & grep -q "1" $1
+ test -f $1 && grep -q "1" $1
}
per_event_options() { # event-dir