We shouldn't pass NULL to XGETQSTAT quotactl since kernel either fails with

EFAULT or reads garbage from NULL address (which makes SELinux spit warnings).
(Jan Kara)

2 files changed, 2 insertions, 1 deletions

diff --git a/Changelog b/Changelog
index 23ff6ba..3d62471 100644
--- a/Changelog
+++ b/Changelog
@@ -1,4 +1,5 @@
 Changes in quota-tools from 3.17 to 4.00-pre2
+* improve detection of XFS kernel quota interface (Jan Kara)
 * support of GFS2 filesystem (Christoph Hellwig)
 * avoid memory corruption of NULL address (Petr Pisar)
 * fixup typos in manpages (Michael Meskes)
diff --git a/quotasys.c b/quotasys.c
index 307a359..5b6996c 100644
--- a/quotasys.c
+++ b/quotasys.c
@@ -754,7 +754,7 @@ void init_kernel_interface(void)
 	else {
 		fs_quota_stat_t dummy;
 
-		if (!quotactl(QCMD(Q_XGETQSTAT, 0), NULL, 0, (void *)&dummy) || (errno != EINVAL && errno != ENOSYS))
+		if (!quotactl(QCMD(Q_XGETQSTAT, 0), "/dev/root", 0, (void *)&dummy) || (errno != EINVAL && errno != ENOSYS))
 			kernel_qfmt[kernel_qfmt_num++] = QF_XFS;
 	}
 	/* Detect new kernel interface; Assume generic interface unless we can prove there is not one... */