diff options
author | sat <takeuchi_satoru@jp.fujitsu.com> | 2012-11-19 03:26:54 +0000 |
---|---|---|
committer | Rich Johnston <rjohnston@sgi.com> | 2012-11-21 08:18:53 -0600 |
commit | b03c662399956609934ff063e9064e15dc7459ac (patch) | |
tree | ee526148c9bddf18c89ae60622f501b74d3f1c8a /include | |
parent | 2a4ed91a018054c2ae187f3cd4ee26141f56234f (diff) |
xfstests: fix to build src/realpath and the correct the existence of target devices
Hi Rich, Eric
(2012/10/27 1:46), Rich Johnston wrote:
> On 06/08/2010 03:03 PM, Eric Sandeen wrote:
>> If you try running xfstests on lvm volumes which are symlinks,
>> it'll fail to run several tests because our _require_scratch
>> framework ultimately uses lstat not stat, and does not think
>> the lvm device (which is usually a symlink to a dm-X device)
>> is a block device. Sigh.
>>
>> Last try at this - just resolve any symlinked devicenames
>> into their realpath(3) in common.config.
>>
>> This actually seems to work.
>>
>> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
>>
>> ---
>>
>>
>> diff --git a/common.config b/common.config
>> index 926846b..e5b2483 100644
>> --- a/common.config
>> +++ b/common.config
>
> Looks good
>
> Reviewed-by: Rich Johnston <rjohnston@sgi.com>
>
> Eric,
>
> This patch has been committed to git://oss.sgi.com/xfs/cmds/xfstests, master branch, commit ID d5ea873f.
From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
Commit d5ea873f is not the same as the the following original Eric's patch.
http://oss.sgi.com/archives/xfs/2010-06/msg00080.html
It does not modify src/Makefile and realpath is never compiled.
In addition, `[ -L $TEST_DEV ]' and `[ -L $SCRATCH_DEV ]' always returns 0
if $TEST_DEV or $SCRATCH_DEV are not defined.
Cc: Eric Sandeen <sandeen@sandeen.net>
Cc: Rich Johnston <rjohnston@sgi.com>
Signed-off-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
Reviewed-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Rich Johnston <rjohnston@sgi.com>
Signed-off-by: Rich Johnston <rjohnston@sgi.com>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions