diff options
author | Petr Pisar <ppisar@redhat.com> | 2011-05-12 13:13:56 +0200 |
---|---|---|
committer | Jan Kara <jack@suse.cz> | 2011-05-16 17:39:33 +0200 |
commit | 3ad0b3622cf92989584097787323f00bc7a36c48 (patch) | |
tree | 60f203a986e4f36d5ae7723258cec91ab277ad0c /setquota.c | |
parent | c3a392437a2ec4793f2b1112058de0c3b459b6fe (diff) |
Make global symbols static as possible
There are some calls (e.g. getpwnam(3)) that can lead to dlopening
other libraries that could jump to symbol with name clashing to one of
global quota symbols. (e.g. Name server switch plug-in nss_db calls
dirname(3) that's already defined in edquota.c and tht can cause
segmentation fault.)
Although it's not possible to solve all these problems, making as much
as possible global objects and functions static is the best thing we
can do to avoid name space polution.
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'setquota.c')
-rw-r--r-- | setquota.c | 10 |
1 files changed, 5 insertions, 5 deletions
@@ -37,12 +37,12 @@ #define FL_NO_MIXED_PATHS 512 #define FL_CONTINUE_BATCH 1024 -int flags, fmt = -1; -char **mnt; +static int flags, fmt = -1; +static char **mnt; char *progname; -int mntcnt; -qid_t protoid, id; -struct util_dqblk toset; +static int mntcnt; +static qid_t protoid, id; +static struct util_dqblk toset; /* Print usage information */ static void usage(void) |